Unexpected types supplied during diagnostic message substitution, ConstantVerifier.

[scheglov]

I see a lot of these in logs.

Thread 0 main threadStateError: Bad state: Unexpected types supplied during diagnostic message substitution.Actual types: []Expected types: [ExpectedType.string, ExpectedType.string]
at _checkTypes(listener.dart:122)
at convertTypeNames(listener.dart:35)
at DiagnosticReporter._createDiagnostic(listener.dart:388)
at DiagnosticReporter.atOffset(listener.dart:310)
at ConstantVerifier._validateConstructorInvocation(constant_verifier.dart:914)
at ConstantVerifier.visitInstanceCreationExpression(constant_verifier.dart:285)
at InstanceCreationExpressionImpl.accept(ast.dart:13709)
at AstNodeExtension.hasConstantVerifierError(constants.dart:95)
at InstanceCreationExpressionImpl.canBeConst(ast.dart:13654)
at _Visitor.visitInstanceCreationExpression(prefer_const_constructors.dart:102)
at InstanceCreationExpressionImpl.accept(ast.dart:13709)
at AnalysisRuleVisitor._runSubscriptions(linter_visitor.g.dart:1120)
at AnalysisRuleVisitor.visitInstanceCreationExpression(linter_visitor.g.dart:533)
at InstanceCreationExpressionImpl.accept(ast.dart:13709)
at NamedExpressionImpl.visitChildren(ast.dart:16659)
at AnalysisRuleVisitor.visitNamedExpression(linter_visitor.g.dart:654)
at NamedExpressionImpl.accept(ast.dart:16647)
at NodeListImpl.accept(ast.dart:17222)
at WithClauseImpl.visitChildren(ast.dart:25508)
at AnalysisRuleVisitor.visitArgumentList(linter_visitor.g.dart:40)
at ArgumentListImpl.accept(ast.dart:579)
at InstanceCreationExpressionImpl.visitChildren(ast.dart:13722)
at AnalysisRuleVisitor.visitInstanceCreationExpression(linter_visitor.g.dart:534)
at InstanceCreationExpressionImpl.accept(ast.dart:13709)
at NodeListImpl.accept(ast.dart:17222)
at WithClauseImpl.visitChildren(ast.dart:25508)
at AnalysisRuleVisitor.visitArgumentList(linter_visitor.g.dart:40)
at ArgumentListImpl.accept(ast.dart:579)
at MethodInvocationImpl.visitChildren(ast.dart:16180)
at AnalysisRuleVisitor.visitMethodInvocation(linter_visitor.g.dart:636)
at MethodInvocationImpl.accept(ast.dart:16166)
at RelationalPatternImpl.visitChildren(ast.dart:20500)
at AnalysisRuleVisitor.visitAwaitExpression(linter_visitor.g.dart:76)
at AwaitExpressionImpl.accept(ast.dart:1613)
at ExpressionStatementImpl.visitChildren(ast.dart:8047)
at AnalysisRuleVisitor.visitExpressionStatement(linter_visitor.g.dart:324)
at ExpressionStatementImpl.accept(ast.dart:8042)
at NodeListImpl.accept(ast.dart:17222)
at CommentImpl.visitChildren(ast.dart:3667)
at AnalysisRuleVisitor.visitBlock(linter_visitor.g.dart:88)
at BlockImpl.accept(ast.dart:1938)
at BlockFunctionBodyImpl.visitChildren(ast.dart:1873)
at AnalysisRuleVisitor.visitBlockFunctionBody(linter_visitor.g.dart:94)
at BlockFunctionBodyImpl.accept(ast.dart:1864)
at FunctionExpressionImpl.visitChildren(ast.dart:11070)
at AnalysisRuleVisitor.visitFunctionExpression(linter_visitor.g.dart:438)
at FunctionExpressionImpl.accept(ast.dart:11057)
at NodeListImpl.accept(ast.dart:17222)
at WithClauseImpl.visitChildren(ast.dart:25508)
at AnalysisRuleVisitor.visitArgumentList(linter_visitor.g.dart:40)
at ArgumentListImpl.accept(ast.dart:579)
at MethodInvocationImpl.visitChildren(ast.dart:16180)
at AnalysisRuleVisitor.visitMethodInvocation(linter_visitor.g.dart:636)
at MethodInvocationImpl.accept(ast.dart:16166)
at ExpressionStatementImpl.visitChildren(ast.dart:8047)
at AnalysisRuleVisitor.visitExpressionStatement(linter_visitor.g.dart:324)
at ExpressionStatementImpl.accept(ast.dart:8042)
at NodeListImpl.accept(ast.dart:17222)
at CommentImpl.visitChildren(ast.dart:3667)
at AnalysisRuleVisitor.visitBlock(linter_visitor.g.dart:88)
at BlockImpl.accept(ast.dart:1938)
at BlockFunctionBodyImpl.visitChildren(ast.dart:1873)
at AnalysisRuleVisitor.visitBlockFunctionBody(linter_visitor.g.dart:94)
at BlockFunctionBodyImpl.accept(ast.dart:1864)
at FunctionExpressionImpl.visitChildren(ast.dart:11070)
at AnalysisRuleVisitor.visitFunctionExpression(linter_visitor.g.dart:438)
at FunctionExpressionImpl.accept(ast.dart:11057)
at FunctionDeclarationImpl.visitChildren(ast.dart:10844)
at AnalysisRuleVisitor.visitFunctionDeclaration(linter_visitor.g.dart:426)
at FunctionDeclarationImpl.accept(ast.dart:10837)
at NodeListImpl.accept(ast.dart:17222)
at CompilationUnitImpl.visitChildren(ast.dart:4018)
at AnalysisRuleVisitor.visitCompilationUnit(linter_visitor.g.dart:166)
at CompilationUnitImpl.accept(ast.dart:3995)
at LibraryAnalyzer._computeLints(library_analyzer.dart:441)
at LibraryAnalyzer._computeDiagnostics(library_analyzer.dart:358)
at LibraryAnalyzer.analyze.<fn>(library_analyzer.dart:125)
at OperationPerformanceImpl.run(operation_performance.dart:180)
at LibraryAnalyzer.analyze(library_analyzer.dart:124)
at AnalysisDriver._analyzeFileImpl.<fn>.<fn>(driver.dart:1373)
at OperationPerformanceImpl.run(operation_performance.dart:180)
at AnalysisDriver._analyzeFileImpl.<fn>(driver.dart:1362)
at PerformanceLog.run(performance_logger.dart:38)
at AnalysisDriver._analyzeFileImpl(driver.dart:1319)
at AnalysisDriver._produceErrors.<fn>.<fn>(driver.dart:2190)
at OperationPerformanceImpl.run(operation_performance.dart:180)
at AnalysisDriver._produceErrors.<fn>(driver.dart:2189)
at OperationPerformanceImpl.run(operation_performance.dart:180)
at AnalysisDriver._produceErrors(driver.dart:2090)
at AnalysisDriver.performWork(driver.dart:1244)
at AnalysisDriverScheduler._run(driver.dart:2682)

[stereotype441]

I don't know the root cause off the top of my head, but I have some ideas about how to narrow it down. I'll work on this.

[stereotype441]

I believe the culprit is this line from ConstantVisitor.visitBinaryExpression:

sdk/pkg/analyzer/lib/src/dart/constant/evaluation.dart

Line 676 in f355c03

throw EvaluationException(constant.diagnosticCode);

What's happening is that if constant evaluation of the RHS of a binary expression results in an error, the diagnostic code is extracted and placed inside an EvaluationException object. Later that EvaluationException is converted back to an InvalidConstant in one of a number of places, for example here:

sdk/pkg/analyzer/lib/src/dart/constant/evaluation.dart

Line 2267 in f355c03

diagnosticCode: exception.diagnosticCode,

But the arguments have been lost. Most constant evaluation errors don't require arguments, so this is usually benign. But if the constant evluation error that happened on the RHS of the binary expression is one that does require arguments, then an exception will be thrown when the InvalidConstant is later passed to the diagnostic reporter, which happens here:

sdk/pkg/analyzer/lib/src/dart/constant/constant_verifier.dart

Line 914 in f355c03

_diagnosticReporter.atOffset(

I'm working on a fix that involves switching constant evaluation over to use the analyzer's new "literate style" of diagnostic reporting, which should make these kinds of exceptions impossible by checking the arguments to diagnostic messages statically at compile time.

I'll also work on a more targeted fix that we could use for cherry-picking to stable, if desired.