Failures on [cfe] Record constant coverage for extension type constructors

[mkustermann]

There are new test failures on [cfe] Record constant coverage for extension type constructors.

The tests

co19/Language/Classes/Constructors/Factories/const_modifier_t04 RuntimeError (expected Pass)
co19/Language/Expressions/Constants/as_type_A01_t01 RuntimeError (expected Pass)
co19/Language/Expressions/Constants/as_type_A01_t02 RuntimeError (expected Pass)
co19/Language/Expressions/Constants/is_not_type_A01_t01 RuntimeError (expected Pass)
co19/Language/Expressions/Constants/is_not_type_A01_t02 RuntimeError (expected Pass)
co19/Language/Expressions/Constants/is_type_A01_t01 RuntimeError (expected Pass)
co19/Language/Expressions/Constants/is_type_A01_t02 RuntimeError (expected Pass)
co19/Language/Expressions/Constants/math_operators_A01_t08 RuntimeError (expected Pass)
co19/Language/Expressions/Constants/math_operators_A01_t09 RuntimeError (expected Pass)
co19/Language/Expressions/Constants/math_operators_A02_t02 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/dynamic_semantics_extension_type_A05_t03 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/dynamic_semantics_extension_type_A06_t03 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/dynamic_semantics_extension_type_A06_t04 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/dynamic_semantics_extension_type_A06_t05 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/exhaustiveness_constant_A01_t01 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/exhaustiveness_constant_A02_t02 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/exhaustiveness_parenthesized_A01_t01 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/exhaustiveness_parenthesized_A01_t03 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A20_t02 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A20_t03 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A20_t04 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A20_t05 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A20_t06 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A20_t07 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A20_t08 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t02 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t08 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t10 RuntimeError (expected Pass)
co19/LanguageFeatures/Extension-types/syntax_A10_t03 RuntimeError (expected Pass)
co19/LanguageFeatures/Static-access-shorthand/constant_expression_A01_t01 RuntimeError (expected Pass)
    and 113 more tests

are failing on configurations

vm-aot-dyn-linux-debug-x64

/cc @alexmarkov

[alexmarkov]

It looks like 2d2b854 added non-Constructor objects to Source.constantCoverageConstructors, which caused crashes in the bytecode generator. We need to add support for those objects (those are likely desugared const constructors in extension types).

2d2b854 is now reverted, so these tests are passing on the tip of the tree.

Example of the failure:

/=============================================================================================================\
| co19/Language/Classes/Constructors/Factories/const_modifier_t04 broke (Pass -> RuntimeError, expected Pass) |
\=============================================================================================================/

--- Command "dart2bytecode" (took 282ms):
DART_CONFIGURATION=DebugX64 out/DebugX64/dartaotruntime out/DebugX64/gen/dart2bytecode.dart.snapshot --platform=out/DebugX64/vm_platform.dill -o /b/s/w/ir/out/DebugX64/generated_compilations/vm-aot-dyn-linux-debug-x64/tests_co19_src_Language_Classes_Constructors_Factories_const_modifier_t04/out.bytecode /b/s/w/ir/tests/co19/src/Language/Classes/Constructors/Factories/const_modifier_t04.dart -Dtest_runner.configuration=vm-aot-dyn-linux-debug-x64 --packages=/b/s/w/ir/.dart_tool/package_config.json -Ddart.vm.product=false --bytecode-options=source-positions,embed-source-text

exit code:
255

stderr:
Unhandled exception:
type 'Procedure' is not a subtype of type 'Constructor' in type cast
#0      Reference.asConstructor (package:kernel/canonical_name.dart:537)
#1      BytecodeGenerator.getScript.<anonymous closure> (package:dart2bytecode/bytecode_generator.dart:232)
#2      MappedIterator.moveNext (dart:_internal/iterable.dart:420)
#3      new _GrowableList._ofEfficientLengthIterable (dart:core-patch/growable_array.dart:194)
#4      new _GrowableList.of (dart:core-patch/growable_array.dart:154)
#5      new List.of (dart:core-patch/array_patch.dart:39)
#6      Iterable.toList (dart:core/iterable.dart:517)
#7      BytecodeGenerator.getScript (package:dart2bytecode/bytecode_generator.dart:233)
#8      BytecodeGenerator.getTopLevelClassDeclaration (package:dart2bytecode/bytecode_generator.dart:368)
#9      BytecodeGenerator.visitLibrary (package:dart2bytecode/bytecode_generator.dart:186)
#10     generateBytecode.<anonymous closure> (package:dart2bytecode/bytecode_generator.dart:77)
#11     Timeline.timeSync (dart:developer/timeline.dart:184)
#12     generateBytecode (package:dart2bytecode/bytecode_generator.dart:69)
#13     runCompilerWithOptions (package:dart2bytecode/dart2bytecode.dart:262)
<asynchronous suspension>
#14     runCompilerWithCommandLineArguments (package:dart2bytecode/dart2bytecode.dart:142)
<asynchronous suspension>
#15     main (package:dart2bytecode/dart2bytecode.dart:100)
<asynchronous suspension>
#16     main (file:///b/f/w/pkg/dart2bytecode/bin/dart2bytecode.dart:8)
<asynchronous suspension>

--- Re-run this test:
python3 tools/test.py -n vm-aot-dyn-linux-debug-x64 co19/Language/Classes/Constructors/Factories/const_modifier_t04

@sstrickl Could you take a look?

[sstrickl]

Missed this at the time, taking a look now.