Internal error in analysis server after upgrade to Flutter 3.38.0.

[nielsenko]

On our CI at serverpod, after updating to Flutter 3.38.0 we see the following error:

ERROR: ERROR: An unexpected error was encountered by the Analysis Server.
Please file an issue at https://github.com/dart-lang/sdk/issues/new/choose with the following details:

Internal error: Exception while using a PreferConstConstructors to visit a InstanceCreationExpressionImpl in VariableDeclarationImpl in VariableDeclarationListImpl in VariableDeclarationStatementImpl in BlockImpl in BlockFunctionBodyImpl in FunctionExpressionImpl in ArgumentListImpl in MethodInvocationImpl in ExpressionStatementImpl in BlockImpl in BlockFunctionBodyImpl in FunctionExpressionImpl in ArgumentListImpl in MethodInvocationImpl in ExpressionStatementImpl in BlockImpl in BlockFunctionBodyImpl in FunctionExpressionImpl in FunctionDeclarationImpl in CompilationUnitImpl
Bad state: Unexpected types supplied during diagnostic message substitution.
Actual types: []
Expected types: [ExpectedType.string, ExpectedType.string]
#0      _checkTypes (package:analyzer/src/error/listener.dart:122)
#1      convertTypeNames (package:analyzer/src/error/listener.dart:35)
#2      DiagnosticReporter._createDiagnostic (package:analyzer/src/error/listener.dart:388)
#3      DiagnosticReporter.atOffset (package:analyzer/src/error/listener.dart:310)
#4      ConstantVerifier._validateConstructorInvocation (package:analyzer/src/dart/constant/constant_verifier.dart:914)
#5      ConstantVerifier.visitInstanceCreationExpression (package:analyzer/src/dart/constant/constant_verifier.dart:285)
#6      InstanceCreationExpressionImpl.accept (package:analyzer/src/dart/ast/ast.dart:13709)
#7      AstNodeExtension.hasConstantVerifierError (package:analyzer/src/lint/constants.dart:95)
#8      InstanceCreationExpressionImpl.canBeConst (package:analyzer/src/dart/ast/ast.dart:13654)
#9      _Visitor.visitInstanceCreationExpression (package:linter/src/rules/prefer_const_constructors.dart:102)
#10     InstanceCreationExpressionImpl.accept (package:analyzer/src/dart/ast/ast.dart:13709)
#11     AnalysisRuleVisitor._runSubscriptions (package:analyzer/src/lint/linter_visitor.g.dart:1120)
#12     AnalysisRuleVisitor.visitInstanceCreationExpression (package:analyzer/src/lint/linter_visitor.g.dart:533)
#13     InstanceCreationExpressionImpl.accept (package:analyzer/src/dart/ast/ast.dart:13709)
#14     VariableDeclarationImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:24784)
#15     AnalysisRuleVisitor.visitVariableDeclaration (package:analyzer/src/lint/linter_visitor.g.dart:1030)
#16     VariableDeclarationImpl.accept (package:analyzer/src/dart/ast/ast.dart:24778)
#17     NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:17220)
#18     VariableDeclarationListImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:24956)
#19     AnalysisRuleVisitor.visitVariableDeclarationList (package:analyzer/src/lint/linter_visitor.g.dart:1036)
#20     VariableDeclarationListImpl.accept (package:analyzer/src/dart/ast/ast.dart:24949)
#21     VariableDeclarationStatementImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:25050)
#22     AnalysisRuleVisitor.visitVariableDeclarationStatement (package:analyzer/src/lint/linter_visitor.g.dart:1042)
#23     VariableDeclarationStatementImpl.accept (package:analyzer/src/dart/ast/ast.dart:25045)
#24     NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:17220)
#25     CommentImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:3667)
#26     AnalysisRuleVisitor.visitBlock (package:analyzer/src/lint/linter_visitor.g.dart:88)
#27     BlockImpl.accept (package:analyzer/src/dart/ast/ast.dart:1938)
#28     BlockFunctionBodyImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:1873)
#29     AnalysisRuleVisitor.visitBlockFunctionBody (package:analyzer/src/lint/linter_visitor.g.dart:94)
#30     BlockFunctionBodyImpl.accept (package:analyzer/src/dart/ast/ast.dart:1864)
#31     FunctionExpressionImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:11070)
#32     AnalysisRuleVisitor.visitFunctionExpression (package:analyzer/src/lint/linter_visitor.g.dart:438)
#33     FunctionExpressionImpl.accept (package:analyzer/src/dart/ast/ast.dart:11057)
#34     NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:17220)
#35     WithClauseImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:25507)
#36     AnalysisRuleVisitor.visitArgumentList (package:analyzer/src/lint/linter_visitor.g.dart:40)
#37     ArgumentListImpl.accept (package:analyzer/src/dart/ast/ast.dart:579)
#38     MethodInvocationImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:16180)
#39     AnalysisRuleVisitor.visitMethodInvocation (package:analyzer/src/lint/linter_visitor.g.dart:636)
#40     MethodInvocationImpl.accept (package:analyzer/src/dart/ast/ast.dart:16166)
#41     ExpressionStatementImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:8047)
#42     AnalysisRuleVisitor.visitExpressionStatement (package:analyzer/src/lint/linter_visitor.g.dart:324)
#43     ExpressionStatementImpl.accept (package:analyzer/src/dart/ast/ast.dart:8042)
#44     NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:17220)
#45     CommentImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:3667)
#46     AnalysisRuleVisitor.visitBlock (package:analyzer/src/lint/linter_visitor.g.dart:88)
#47     BlockImpl.accept (package:analyzer/src/dart/ast/ast.dart:1938)
#48     BlockFunctionBodyImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:1873)
#49     AnalysisRuleVisitor.visitBlockFunctionBody (package:analyzer/src/lint/linter_visitor.g.dart:94)
#50     BlockFunctionBodyImpl.accept (package:analyzer/src/dart/ast/ast.dart:1864)
#51     FunctionExpressionImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:11070)
#52     AnalysisRuleVisitor.visitFunctionExpression (package:analyzer/src/lint/linter_visitor.g.dart:438)
#53     FunctionExpressionImpl.accept (package:analyzer/src/dart/ast/ast.dart:11057)
#54     NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:17220)
#55     WithClauseImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:25507)
#56     AnalysisRuleVisitor.visitArgumentList (package:analyzer/src/lint/linter_visitor.g.dart:40)
#57     ArgumentListImpl.accept (package:analyzer/src/dart/ast/ast.dart:579)
#58     MethodInvocationImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:16180)
#59     AnalysisRuleVisitor.visitMethodInvocation (package:analyzer/src/lint/linter_visitor.g.dart:636)
#60     MethodInvocationImpl.accept (package:analyzer/src/dart/ast/ast.dart:16166)
#61     ExpressionStatementImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:8047)
#62     AnalysisRuleVisitor.visitExpressionStatement (package:analyzer/src/lint/linter_visitor.g.dart:324)
#63     ExpressionStatementImpl.accept (package:analyzer/src/dart/ast/ast.dart:8042)
#64     NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:17220)
#65     CommentImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:3667)
#66     AnalysisRuleVisitor.visitBlock (package:analyzer/src/lint/linter_visitor.g.dart:88)
#67     BlockImpl.accept (package:analyzer/src/dart/ast/ast.dart:1938)
#68     BlockFunctionBodyImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:1873)
#69     AnalysisRuleVisitor.visitBlockFunctionBody (package:analyzer/src/lint/linter_visitor.g.dart:94)
#70     BlockFunctionBodyImpl.accept (package:analyzer/src/dart/ast/ast.dart:1864)
#71     FunctionExpressionImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:11070)
#72     AnalysisRuleVisitor.visitFunctionExpression (package:analyzer/src/lint/linter_visitor.g.dart:438)
#73     FunctionExpressionImpl.accept (package:analyzer/src/dart/ast/ast.dart:11057)
#74     FunctionDeclarationImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:10844)
#75     AnalysisRuleVisitor.visitFunctionDeclaration (package:analyzer/src/lint/linter_visitor.g.dart:426)
#76     FunctionDeclarationImpl.accept (package:analyzer/src/dart/ast/ast.dart:10837)
#77     NodeListImpl.accept (package:analyzer/src/dart/ast/ast.dart:17220)
#78     CompilationUnitImpl.visitChildren (package:analyzer/src/dart/ast/ast.dart:4018)
#79     AnalysisRuleVisitor.visitCompilationUnit (package:analyzer/src/lint/linter_visitor.g.dart:166)
#80     CompilationUnitImpl.accept (package:analyzer/src/dart/ast/ast.dart:3995)
#81     LibraryAnalyzer._computeLints (package:analyzer/src/dart/analysis/library_analyzer.dart:441)
#82     LibraryAnalyzer._computeDiagnostics (package:analyzer/src/dart/analysis/library_analyzer.dart:358)
#83     LibraryAnalyzer.analyze.<anonymous closure> (package:analyzer/src/dart/analysis/library_analyzer.dart:125)
#84     OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:180)
#85     LibraryAnalyzer.analyze (package:analyzer/src/dart/analysis/library_analyzer.dart:124)
#86     AnalysisDriver._analyzeFileImpl.<anonymous closure>.<anonymous closure> (package:analyzer/src/dart/analysis/driver.dart:1370)
#87     OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:180)
#88     AnalysisDriver._analyzeFileImpl.<anonymous closure> (package:analyzer/src/dart/analysis/driver.dart:1359)
#89     PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:38)
#90     AnalysisDriver._analyzeFileImpl (package:analyzer/src/dart/analysis/driver.dart:1316)
#91     AnalysisDriver._produceErrors.<anonymous closure>.<anonymous closure> (package:analyzer/src/dart/analysis/driver.dart:2167)
#92     OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:180)
#93     AnalysisDriver._produceErrors.<anonymous closure> (package:analyzer/src/dart/analysis/driver.dart:2166)
#94     OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:180)
#95     AnalysisDriver._produceErrors (package:analyzer/src/dart/analysis/driver.dart:2067)
#96     AnalysisDriver.performWork (package:analyzer/src/dart/analysis/driver.dart:1241)
#97     AnalysisDriverScheduler._run (package:analyzer/src/dart/analysis/driver.dart:2659)
<asynchronous suspension>


null

[FMorschel]

CC @scheglov

[bwilkerson]

@stereotype441

[stereotype441]

This is a duplicate of #61761, which was fixed in https://dart-review.googlesource.com/c/sdk/+/460201; that rolled into the Dart dev channel as of 3.11.0-108.0.dev, but hasn't rolled into Dart beta yet. Unfortunately, Flutter 3.38.0 is on Dart version 3.10.0-290.4.beta, so it doesn't include the fix.

@bwilkerson do you think we should cherry-pick https://dart-review.googlesource.com/c/sdk/+/460201 to beta?

[bwilkerson]

I think it's small enough that it could be considered, and I think that we've had two bug reports about it so it's probably impacting enough users to try to get it in.

[stereotype441]

Ok, the cherry pick has landed and should go out in the next stable release.