[Dot shorthands] Dot shorthands break constructor references and completions

[PiotrRogulski]

When I use dot shorthands to call a constructor (e.g. .new()), the "go to declaration" action doesn't work:

Also, constructor parameters aren't being suggested (here, observers should be suggested, definitely not allocateOneByteString):

Debug info

#### General info

- Dart 3.11.0-128.0.dev (dev) (Wed Nov 12 12:03:39 2025 -0800) on "macos_arm64"
- on macos / Version 26.2 (Build 25C5037j)
- locale is en-US

#### Project info

- sdk constraint: '3.11.0-128.0.dev'
- dependencies: archive, cached_query_flutter, cached_storage, collection, dio, equatable, flutter, flutter_adaptive_scaffold, flutter_localizations, flutter_staggered_grid_view, gap, go_router, kana_kit, leancode_hooks, logging, meta, pretty_dio_logger, provider, sqflite_common_ffi, sqflite_common_ffi_web, svg_path_parser, url_launcher, xml
- dev_dependencies: arb_utils, build_runner, characters, code_builder, dart_style, file, go_router_builder, leancode_lint
- elided dependencies: 2

#### Process info

|  Memory |  CPU | Elapsed time | Command line                                                                               |
| ------: | ---: | -----------: | ------------------------------------------------------------------------------------------ |
|   13 MB | 0.0% |     10:00:11 | dart devtools --machine --dtd-uri=ws:<path>/0ZPLsRjjBdA=                                   |
|   12 MB | 0.0% |     10:00:12 | dart devtools --machine --dtd-uri=ws:<path>/Ds0IoNdR9s8=                                   |
|   14 MB | 0.0% |     10:00:10 | dart devtools --machine --dtd-uri=ws:<path>/iYmG1BzHbvU=                                   |
| 1035 MB | 1.0% |     10:00:15 | dart language-server --client-id=Android-Studio --client-version=AI-252.25557.131 --protocol=analyzer |
|   13 MB | 0.0% |     10:00:12 | dart tooling-daemon --machine                                                              |
|   40 MB | 0.0% |     10:00:16 | flutter_tools.snapshot daemon                                                              |
|   40 MB | 0.0% |     10:00:15 | flutter_tools.snapshot daemon                                                              |
|   40 MB | 0.0% |     10:00:13 | flutter_tools.snapshot daemon                                                              |

[PiotrRogulski]

For a minimal example, here it doesn't work either (broadcast isn't suggested):

Stream<int> get aStream => const .empty(^);

[FMorschel]

CC @kallentu @bwilkerson

I'll see first about the completion. If anyone wants to handle the Go to Declaration while I'm at it, feel free to do so. But once I complete that, I'll start working on it if nobody mentions it in a new comment.

[FMorschel]

Here is the first CL. It was way easier than I thought. I'll take a look at the other case now.

https://dart-review.googlesource.com/c/sdk/+/462081

[FMorschel]

Okay;

• This one (Go to Definition problem) is happening only on legacy/IntelliJ, not LSP
• Rename is broken for constructors (not static methods), where it adds a new .

class A {
  A();
  static A foo() => A();
}
A a = .new();
A a2 = .foo();

If you try to rename the constructor in either position, it adds a new . on dot-shorthand invocations.

[FMorschel]

I'm still looking, but I'm not sure where the Go to Definition occurs for legacy/IntelliJ. Maybe that happens under the plugin? Does anyone know?

CC @jwren @pq @helin24

[FMorschel]

In the mean time, I've fixed the renaming with https://dart-review.googlesource.com/c/sdk/+/461981

[FMorschel]

@kallentu, I'm not sure about the timeline here for the first patch, but I'd say the above fixes on DAS would be probably good to consider. At least the completion one.

I'm not sure about the Go to Definition because I think that is done at the IntelliJ plugin (I couldn't find anything where I looked), but if that is the case, a new plugin version would solve that.

[kallentu]

[@kallentu](https://github.com/kallentu), I'm not sure about the timeline here for the first patch, but I'd say the above fixes on DAS would be probably good to consider. At least the completion one.

That sounds good. Making another CP hotfix for the above fixes.

[jwren]

I'm still looking, but I'm not sure where the Go to Definition occurs for legacy/IntelliJ. Maybe that happens under the plugin? Does anyone know?

CC [@jwren](https://github.com/jwren) [@pq](https://github.com/pq) [@helin24](https://github.com/helin24)

I always command click, the action in IJ is "Go to Declaration or usages"

[FMorschel]

Yes, neither works. Not the keybind nor the context menu, I've tested it. But I could not find where this code exists in the SDK. The only place I know is working with LSP. This might be an IJ plugin bug, but I'm not familiar with that code to fix it.