refactor: Clean up Invoke calls in dart_entry #56309
Conversation
|
We've not actually landed this in our repo yet (the bots are still running), but I can update this when we do. |
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/377266 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
This reduces the number of #define switches for this file. I also think the TESTING + DART_PRECOMPILED_RUNTIME block was never actually compiled, so this fixes the type conversions in that case if it ever is compiled. We did this upstream in Shorebird to make it easier to change the invoke syntax (to make the simulator dynamically switchable) but the clean-up seemed worth sending upstream too.
|
https://dart-review.googlesource.com/c/sdk/+/377266 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/377266 has been updated with the latest commits from this pull request. |
1 participant
This reduces the number of #define switches for this file.
I also think the TESTING + DART_PRECOMPILED_RUNTIME block was never actually compiled, so this fixes the type conversions in that case if it ever is compiled.
We did this upstream in Shorebird to make it easier to change the invoke syntax (to make the simulator dynamically switchable) but the clean-up seemed worth sending upstream too.