Skip to content

Conversation

@AgamAgarwal
Copy link
Contributor

Fixes #61815


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Contributions to our repos should follow the Dart style guide and use dart format.

Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.

@copybara-service
Copy link

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/457460

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

@FMorschel
Copy link
Contributor

Thanks for fixing this!

@FMorschel
Copy link
Contributor

Note that you'll need to close the issue manually after that CL lands. If you can ask a reviewer to change the description to contain Fixes: <issue-url>, it may close the issue. Otherwise, it will, as stated there, close this PR and not merge it. The merging happens with Copybara somewhere else. And since this will not be merged, it doesn't close the linked issue.

@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/457460 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service
Copy link

https://dart-review.googlesource.com/c/sdk/+/457460 has been updated with the latest commits from this pull request.

@AgamAgarwal AgamAgarwal deleted the ctfd-class-field branch October 25, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

convert_to_function_declaration fails for class fields

2 participants