Fix check for implemented interfaces #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `interfaces` getter does not behave as expected. See dart-lang/sdk#27947 This code was safe before since List happened to explicitly have `implements Iterable`, but now that there is an `EfficientLengthIterable` interface in between it isn't working. Recursively check interfaces the same way we recursively check the superclass. This now ignores the edge case where multiple interfaces matched the tester and will return the first match.
kevmoo
approved these changes
Nov 30, 2016
Member
kevmoo
left a comment
kevmoo
left a comment
There was a problem hiding this comment.
– do you want to release this, though? bump the version, changelog, etc?
Member
Author
|
Added changelog. Version was bumped in the last commit so I'll publish with this fix |
jakemac53
approved these changes
Nov 30, 2016
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
The `interfaces` getter does not behave as hoped. See dart-lang/sdk#27947 This code was safe before since List happened to explicitly have `implements Iterable`, but now that there is an `EfficientLengthIterable` interface in between it isn't working. Recursively check interfaces the same way we recursively check the superclass. This now ignores the edge case where multiple interfaces matched the tester and will return the first match.
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
The `interfaces` getter does not behave as hoped. See dart-lang/sdk#27947 This code was safe before since List happened to explicitly have `implements Iterable`, but now that there is an `EfficientLengthIterable` interface in between it isn't working. Recursively check interfaces the same way we recursively check the superclass. This now ignores the edge case where multiple interfaces matched the tester and will return the first match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
interfacesgetter does not behave as expected. Seedart-lang/sdk#27947
This code was safe before since List happened to explicitly have
implements Iterable, but now that there is anEfficientLengthIterableinterface in between it isn't working.Recursively check interfaces the same way we recursively check the
superclass. This now ignores the edge case where multiple interfaces
matched the tester and will return the first match.