Drop unused methods from utils.dart #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is not exported so there (hopefully) shouldn't be usage of any of these methods outside of this package. - Drop the methods that have no usage in this package - Move the methods used only from tests to a library under test/
kevmoo
approved these changes
Jan 7, 2017
|
We could probably do without some of these methods even in the tests... Moving it out of lib/ is the low hanging fruit |
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
This file is not exported so there (hopefully) shouldn't be usage of any of these methods outside of this package. - Drop the methods that have no usage in this package - Move the methods used only from tests to a library under test/ - Move cli_util to dev_dependencies
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
This file is not exported so there (hopefully) shouldn't be usage of any of these methods outside of this package. - Drop the methods that have no usage in this package - Move the methods used only from tests to a library under test/ - Move cli_util to dev_dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is not exported so there (hopefully) shouldn't be usage of any
of these methods outside of this package.