Skip to content

Use the new log from build #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
natebosch merged 1 commit into from
Feb 14, 2017
Merged

Use the new log from build #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.5.4+2

* Use the new `log` field instead of the deprecated `buildStep.logger`

## 0.5.4+1

* Give more information when `dartfmt` fails.
Expand Down
10 changes: 5 additions & 5 deletions lib/src/builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class GeneratorBuilder extends Builder {

Future _generateForLibrary(
LibraryElement library, BuildStep buildStep) async {
buildStep.logger.fine('Running $generators for ${buildStep.inputId}');
log.fine('Running $generators for ${buildStep.inputId}');
var generatedOutputs =
await _generate(library, generators, buildStep).toList();

Expand Down Expand Up @@ -77,7 +77,7 @@ class GeneratorBuilder extends Builder {
try {
genPartContent = formatter.format(genPartContent);
} catch (e, stack) {
buildStep.logger.severe(
log.severe(
'Error formatting generated source code for ${library.identifier}'
'which was output to ${_generatedFile(buildStep.inputId).path}.\n'
'This may indicate an issue in the generated code or in the '
Expand Down Expand Up @@ -107,15 +107,15 @@ Stream<GeneratedOutput> _processUnitMember(
Element element, List<Generator> generators, BuildStep buildStep) async* {
for (var gen in generators) {
try {
buildStep.logger.finer('Running $gen for $element');
log.finer('Running $gen for $element');
var createdUnit = await gen.generate(element, buildStep);

if (createdUnit != null) {
buildStep.logger.finest(() => 'Generated $createdUnit for $element');
log.finest(() => 'Generated $createdUnit for $element');
yield new GeneratedOutput(element, gen, createdUnit);
}
} catch (e, stack) {
buildStep.logger.severe('Error running $gen for $element.', e, stack);
log.severe('Error running $gen for $element.', e, stack);
yield new GeneratedOutput.fromError(element, gen, e, stack);
}
}
Expand Down
4 changes: 2 additions & 2 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: source_gen
version: 0.5.4+1
version: 0.5.4+2
author: Dart Team <misc@dartlang.org>
description: Automatic sourcecode generation for Dart
homepage: https://github.com/dart-lang/source_gen
environment:
sdk: '>=1.12.0 <2.0.0'
dependencies:
analyzer: ^0.29.2
build: ^0.7.0
build: ^0.7.1
dart_style: '>=0.1.7 <0.3.0'
path: ^1.3.2
dev_dependencies:
Expand Down