Skip to content

Added isAssignableFrom(Type) to TypeChecker #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2017
Merged

Added isAssignableFrom(Type) to TypeChecker #164

merged 2 commits into from
Jun 19, 2017

Conversation

@kevmoo
Copy link
Member

@kevmoo kevmoo commented Jun 19, 2017

Building off #153

@googlebot
Copy link

googlebot commented Jun 19, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot
Copy link

googlebot commented Jun 19, 2017

CLAs look good, thanks!

@natebosch
Copy link
Member

natebosch commented Jun 19, 2017

Commit messages aren't very descriptive...

@kevmoo kevmoo changed the title WIP - More better Added isAssignableFrom(Type) to TypeChecker Jun 19, 2017
@kevmoo
Copy link
Member Author

kevmoo commented Jun 19, 2017

@jakemac53 PTAL
@natebosch I didn't ask you 👅

@kevmoo
Copy link
Member Author

kevmoo commented Jun 19, 2017

@matanlurey FYI...

matanlurey
matanlurey approved these changes Jun 19, 2017
View reviewed changes
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kevin, looks nice :)

kevmoo
kevmoo commented Jun 19, 2017
View reviewed changes
lib/src/json_serializable/type_helper.dart
bool canDeserialize(DartType type) => _matchesType(type);

bool _matchesType(DartType type) =>
type.element.library?.isDartCore == true && type.name == 'DateTime';
Copy link
Member Author

@kevmoo kevmoo Jun 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matanlurey Dude – this is soooo much better. I was looking into cleaning this up for a while. Love your solution...

@kevmoo kevmoo merged commit 93b006d into master Jun 19, 2017
@kevmoo kevmoo deleted the more_better branch June 19, 2017 20:28
mosuem pushed a commit to dart-lang/build that referenced this pull request Dec 10, 2024
@kevmoo
Added isAssignableFrom(Type) to TypeChecker (dart-lang/source_gen#164)
c7877e6 
* Added `isAssignableFrom(Type)` to TypeChecker
* migrate JSON classes to new TypeChecker methods
mosuem pushed a commit to dart-lang/build that referenced this pull request Dec 10, 2024
@kevmoo
Added isAssignableFrom(Type) to TypeChecker (dart-lang/source_gen#164)
558f3d4 
* Added `isAssignableFrom(Type)` to TypeChecker
* migrate JSON classes to new TypeChecker methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kevmoo @googlebot @natebosch @matanlurey @jakemac53