Add types to ConstantReader, fix issue with parts, migrate annotation helpers #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
force-pushed
the
reviver_hacks
branch
2 times, most recently
from
d070fad to
14e2274
Compare
aligns with URL behavior of _MirrorTypeChecker - which also returns the library URI (not the part)
kevmoo
changed the title
kevmoo
commented
Jun 23, 2017
| /// Returns a [DartType] representing this as a `Type` value. | ||
| /// | ||
| /// Throws [FormatException] if [isType] is `false`. | ||
| DartType get typeValue; |
There was a problem hiding this comment.
@matanlurey – can't get the actual Type because runtime vs static.
kevmoo
commented
Jun 23, 2017
| _object.toIntValue() ?? | ||
| _object.toStringValue() ?? | ||
| _object.toDoubleValue() ?? | ||
| (isSymbol ? this.symbolValue : null) ?? |
There was a problem hiding this comment.
Special case here to return an actual Symbol and not a String
matanlurey
reviewed
Jun 23, 2017
| var annotationObject = annotation.constantValue; | ||
| try { | ||
| return _getValue(annotationObject, annotation.element.context.typeProvider); | ||
| return _getValue(annotation.constantValue); |
There was a problem hiding this comment.
AFAIK you always want to use computeConstantValue.
There was a problem hiding this comment.
Just ran a little test – in all cases constantValue and computeConstantValue return the same result. 🤷♂️
| dynamic _getValue(DartObject object) { | ||
| var reader = new ConstantReader(object); | ||
|
|
||
| if (reader.isNull) { |
There was a problem hiding this comment.
Optional: You can use anyValue for this purpose if you'd like.
There was a problem hiding this comment.
Sadly no, we need to talk about that.
Type, List, and Map are weird – you get DartType.
I think we should update anyValue to exclude those and explain why.
| bool get isType => _object.toTypeValue() != null; | ||
|
|
||
| @override | ||
| DartType get typeValue => |
There was a problem hiding this comment.
Consistent use of ' please.
| @override | ||
| bool get isDouble => false; | ||
|
|
||
| @override |
| @override | ||
| bool get isSymbol => false; | ||
|
|
||
| @override |
| @override | ||
| get isType => false; | ||
|
|
||
| @override |
matanlurey
approved these changes
Jun 23, 2017
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
… helpers (dart-lang/source_gen#184) * ConstantReader: Add Symbol, Type, double * urlOfElement: use librarySource.uri aligns with URL behavior of _MirrorTypeChecker - which also returns the library URI (not the part) * Migrate annotation helpers to TypeChecker and ConstantReader
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
… helpers (dart-lang/source_gen#184) * ConstantReader: Add Symbol, Type, double * urlOfElement: use librarySource.uri aligns with URL behavior of _MirrorTypeChecker - which also returns the library URI (not the part) * Migrate annotation helpers to TypeChecker and ConstantReader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.