Patch internal cases, bump. #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
approved these changes
Jun 27, 2017
| var contentBuffer = new StringBuffer(); | ||
| // Don't output useless files. | ||
| // | ||
| // NOTE: It is important to do this check _before_ checking for valid |
There was a problem hiding this comment.
Would prefer if this was protected by a test rather than a comment. Can you file an issue so we can followup later?
|
@matanlurey – were you going to publish? |
|
I'm trying to land .9 with patches still - once I do we can release .10. That way we don't need a .11 if I missed something :) |
|
You're a wise man...
…On Tue, Jun 27, 2017 at 8:17 AM, Matan Lurey ***@***.***> wrote:
I'm trying to land .9 with patches still - once I do we can release .10.
That way we don't need a .11 if I missed something :)
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#191 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCitT3lFV1h3zlInfCstz1gMGHGLeDks5sIRz9gaJpZM4OGBz6>
.
|
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in
builder.dartspecifically were required to land internally.