Skip to content

Conversation

@camsteffen
Copy link
Contributor

lib/src/revive.dart line 26 makes a call to DartObjectImpl#getInvocation() which requires analyzer 0.29.10.

increase analyzer min version
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@camsteffen
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending green on travis, I'll merge!

Thanks for the contribution!

@jakemac53
Copy link
Contributor

Looks good, do you mind bumping the version in the pubspec (just a +1 release) and adding a changelog entry?

@camsteffen
Copy link
Contributor Author

right now the version is 0.5.11-dev. Should I change it to 0.5.10+1?

@kevmoo
Copy link
Member

kevmoo commented Jun 28, 2017

@camsteffen that sounds right – we should make sure the CHANGELOG is updated, too

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot
Copy link

CLAs look good, thanks!

@kevmoo kevmoo merged commit 4c50faf into dart-lang:master Jun 28, 2017
@kevmoo
Copy link
Member

kevmoo commented Jun 28, 2017

Published and tagged. Thanks!

mosuem pushed a commit to dart-lang/build that referenced this pull request Dec 10, 2024
* Update pubspec.yaml
* prepare 0.5.10+1
mosuem pushed a commit to dart-lang/build that referenced this pull request Dec 10, 2024
* Update pubspec.yaml
* prepare 0.5.10+1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants