Generate with LibraryReader over LibraryElement #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to ConstantReader this will make it easier to use new utility methods as we add them. - Make `_element` public so that clients can still access the `LibraryElement` when needed. - Change the `generate` method signature and all implementations. - Wrap the argument in `builder.dart`.
matanlurey
approved these changes
Jul 21, 2017
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
…#239) Similar to ConstantReader this will make it easier to use new utility methods as we add them. - Make `_element` public so that clients can still access the `LibraryElement` when needed. - Change the `generate` method signature and all implementations. - Wrap the argument in `builder.dart`.
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
…#239) Similar to ConstantReader this will make it easier to use new utility methods as we add them. - Make `_element` public so that clients can still access the `LibraryElement` when needed. - Change the `generate` method signature and all implementations. - Wrap the argument in `builder.dart`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to ConstantReader this will make it easier to use new utility
methods as we add them.
_elementpublic so that clients can still access theLibraryElementwhen needed.generatemethod signature and all implementations.builder.dart.