Skip to content

More redundant newline elimination, prepare for 0.8.1+3 #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2018
Merged

More redundant newline elimination, prepare for 0.8.1+3 #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.8.1+3

* More redundant new lines elimination.

## 0.8.1+2

* Eliminate redundant new lines in the core builder. These were almost removed
Expand Down
6 changes: 2 additions & 4 deletions lib/src/builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class _Builder extends Builder {
},
_isStandalone = isStandalone,
formatOutput = formatOutput ?? _formatter.format,
_header = header ?? defaultFileHeader {
_header = (header ?? defaultFileHeader).trim() {
if (_generatedExtension == null) {
throw new ArgumentError.notNull('generatedExtension');
}
Expand Down Expand Up @@ -107,7 +107,6 @@ class _Builder extends Builder {
}
contentBuffer.writeln();
contentBuffer.writeln('part of $name;');
contentBuffer.writeln();
}

for (var output in generatedOutputs) {
Expand Down Expand Up @@ -226,7 +225,6 @@ Stream<GeneratedOutput> _generate(LibraryElement library,

final _formatter = new DartFormatter();

const defaultFileHeader = '''// GENERATED CODE - DO NOT MODIFY BY HAND
''';
const defaultFileHeader = '// GENERATED CODE - DO NOT MODIFY BY HAND';

final _headerLine = '// '.padRight(77, '*');
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: source_gen
version: 0.8.1+2
version: 0.8.1+3
author: Dart Team <misc@dartlang.org>
description: Automated source code generation for Dart.
homepage: https://github.com/dart-lang/source_gen
Expand Down