Skip to content

Conditionally import coverage logic #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2019
Merged

Conditionally import coverage logic #1091

merged 2 commits into from
Oct 9, 2019

Conversation

@grouma
Copy link
Member

@grouma grouma commented Oct 9, 2019

Closes #1090

@grouma grouma requested a review from jakemac53 October 9, 2019 18:18
natebosch
natebosch approved these changes Oct 9, 2019
View reviewed changes
pkgs/test_core/lib/src/runner/coverage.dart Outdated
import 'runner_suite.dart';

/// Collects coverage and outputs to the [coverage] path.
Future<Null> gatherCoverage(
Copy link
Member

@natebosch natebosch Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future<void>

@grouma grouma merged commit ee7c02b into master Oct 9, 2019
@grouma grouma deleted the fix-platform-issue branch October 9, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

@natebosch natebosch natebosch approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests are failing to compile to dart2js/DDC in 1.9.0 due to coverage additions

4 participants

@grouma @jakemac53 @natebosch @googlebot