Skip to content

Avoid importing all of test_core from load_suite #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Avoid importing all of test_core from load_suite #1337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkgs/test_core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## 0.3.12-nullsafety.5-dev

## 0.3.12-nullsafety.4

* Support latest `package:vm_service`.
Expand Down
11 changes: 5 additions & 6 deletions pkgs/test_core/lib/src/runner/load_suite.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,10 @@ import 'package:test_api/src/backend/suite.dart'; // ignore: implementation_impo
import 'package:test_api/src/backend/suite_platform.dart'; // ignore: implementation_imports
import 'package:test_api/src/backend/test.dart'; // ignore: implementation_imports
import 'package:test_api/src/utils.dart'; // ignore: implementation_imports
// ignore: deprecated_member_use
import 'package:test_api/test_api.dart' show Timeout;

import '../../test_core.dart';
import '../util/io_stub.dart'
// ignore: uri_does_not_exist
if (dart.library.io) '../util/io.dart';
import '../util/io_stub.dart' if (dart.library.io) '../util/io.dart';
import 'load_exception.dart';
import 'plugin/environment.dart';
import 'runner_suite.dart';
Expand Down Expand Up @@ -76,7 +75,7 @@ class LoadSuite extends Suite implements RunnerSuite {
///
/// Load suites are guaranteed to only contain one test. This is a utility
/// method for accessing it directly.
Test get test => this.group.entries.single as Test;
Test get test => group.entries.single as Test;

/// Creates a load suite named [name] on [platform].
///
Expand Down Expand Up @@ -199,7 +198,7 @@ class LoadSuite extends Suite implements RunnerSuite {

@override
LoadSuite filter(bool Function(Test) callback) {
var filtered = this.group.filter(callback);
var filtered = group.filter(callback);
filtered ??= Group.root([], metadata: metadata);
return LoadSuite._filtered(this, filtered);
}
Expand Down
2 changes: 1 addition & 1 deletion pkgs/test_core/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: test_core
version: 0.3.12-nullsafety.4
version: 0.3.12-nullsafety.5-dev
description: A basic library for writing tests and running them on the VM.
homepage: https://github.com/dart-lang/test/blob/master/pkgs/test_core

Expand Down