Skip to content

Remove duplicate private constructor #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Remove duplicate private constructor #1574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkgs/test_core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## 0.4.3-dev

## 0.4.2

* Re-use the cached dill file from previous runs on subsequent runs.
Expand Down
4 changes: 1 addition & 3 deletions pkgs/test_core/lib/src/runner/runner_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ class RunnerTest extends Test {

RunnerTest(this.name, this.metadata, this.trace, this._channel);

RunnerTest._(this.name, this.metadata, this.trace, this._channel);

@override
LiveTest load(Suite suite, {Iterable<Group>? groups}) {
late final LiveTestController controller;
Expand Down Expand Up @@ -103,6 +101,6 @@ class RunnerTest extends Test {
@override
Test? forPlatform(SuitePlatform platform) {
if (!metadata.testOn.evaluate(platform)) return null;
return RunnerTest._(name, metadata.forPlatform(platform), trace, _channel);
return RunnerTest(name, metadata.forPlatform(platform), trace, _channel);
}
}
2 changes: 1 addition & 1 deletion pkgs/test_core/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: test_core
version: 0.4.2
version: 0.4.3-dev
description: A basic library for writing tests and running them on the VM.
homepage: https://github.com/dart-lang/test/blob/master/pkgs/test_core

Expand Down