Skip to content

Conversation

@greenart7c3
Copy link
Contributor

@greenart7c3 greenart7c3 commented Nov 12, 2025

Fix #2480


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@greenart7c3 greenart7c3 requested a review from a team as a code owner November 12, 2025 17:15
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@greenart7c3
Copy link
Contributor Author

Do i need to put the -wip in the changelog too?

@kevmoo
Copy link
Member

kevmoo commented Nov 12, 2025

Do i need to put the -wip in the changelog too?

Yes, please!

@jakemac53
Copy link
Contributor

@srujzs should we be migrating to package:web? It looks like we currently use dart:js_interop and dart:js_interop_unsafe and have our own extension types. See https://github.com/dart-lang/test/blob/master/pkgs/test/lib/src/runner/browser/dom.dart and https://github.com/dart-lang/test/blob/master/pkgs/test/lib/src/runner/browser/post_message_channel.dart as examples.

@jakemac53 jakemac53 merged commit 80a4934 into dart-lang:master Nov 12, 2025
56 checks passed
@kevmoo
Copy link
Member

kevmoo commented Nov 12, 2025

@srujzs should we be migrating to package:web? It looks like we currently use dart:js_interop and dart:js_interop_unsafe and have our own extension types. See https://github.com/dart-lang/test/blob/master/pkgs/test/lib/src/runner/browser/dom.dart and https://github.com/dart-lang/test/blob/master/pkgs/test/lib/src/runner/browser/post_message_channel.dart as examples.

I think we were trying to avoid dependency loops. But we could!

@srujzs
Copy link

srujzs commented Nov 12, 2025

I think we were trying to avoid dependency loops. But we could!

Are you referring to the dev dependency on test in web?

re: migrating to package:web, sure. I don't think it functionally makes a difference but that's less code to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test uses a deprecated package (js)

4 participants