Skip to content

Conversation

@pq
Copy link
Member

@pq pq commented Jul 26, 2017

FYI @kevmoo

(Not for landing.)

@kevmoo
Copy link
Member

kevmoo commented Jul 26, 2017

Thank you!

@pq pq mentioned this pull request Jul 26, 2017
@pq
Copy link
Member Author

pq commented Jul 26, 2017

Looks good to me. The breakage on Dart 1.23 is unsurprising and I take it not an issue. Having said that, we should maybe consider upping the Dart SDK constraints for front_end to be more than cosmetic (cc @sigmundch) since it can't run on anything less than 1.24.

image

@pq
Copy link
Member Author

pq commented Jul 26, 2017

cc @grouma @stereotype441

@kevmoo
Copy link
Member

kevmoo commented Jul 27, 2017

Well, in the "real world" I'm guessing pkg/analyzer explicitly restricts 1.23, so this solve won't happen – right?

@kevmoo kevmoo closed this Jul 27, 2017
@pq
Copy link
Member Author

pq commented Jul 27, 2017

Well, in the "real world" I'm guessing pkg/analyzer explicitly restricts 1.23, so this solve won't happen – right?

Actually no,

environment:
  sdk: '>=1.20.0 <2.0.0-dev.infinity'

FYI: @bwilkerson --- maybe worth bumping to 1.24.

@kevmoo kevmoo deleted the pq-smoke-0.31.0-alpha.0 branch July 27, 2017 15:16
@kevmoo
Copy link
Member

kevmoo commented Jul 27, 2017

Discussed in email...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants