Stop importing dart:io from browser libraries #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot that this wasn't supported in Dart 1.24 😝. Closes #781
|
fwiw I have verified this branch passes in CI for us :) |
grouma
approved these changes
Mar 7, 2018
Member
|
Which versions is it supported in? |
Member
Author
|
@lrhn Unfortunately the changelog doesn't seem to mention it, so it's hard to tell. |
Member
|
It was landed a year ago, and I haven't heard that the feature was removed (and neither has @johnniwinther). Maybe it's a bug? |
Member
Author
|
Maybe it didn't make it into content shell in particular? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that this wasn't supported in Dart 1.24 😝.
Closes #781