-
Couldn't load subscription status.
- Fork 76
Test new link to directory races, fix for them #2223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with
Coverage
|
| File | Coverage |
|---|---|
| pkgs/watcher/lib/src/directory_watcher/windows.dart | 💔 0 % ⬇️ NaN % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbol | Leaking sources |
|---|
This check can be disabled by tagging the PR with skip-leaking-check.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/bazel_worker/benchmark/benchmark.dart |
| pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart |
| pkgs/boolean_selector/example/example.dart |
| pkgs/clock/lib/clock.dart |
| pkgs/clock/lib/src/clock.dart |
| pkgs/clock/lib/src/default.dart |
| pkgs/clock/lib/src/stopwatch.dart |
| pkgs/clock/lib/src/utils.dart |
| pkgs/clock/test/clock_test.dart |
| pkgs/clock/test/default_test.dart |
| pkgs/clock/test/stopwatch_test.dart |
| pkgs/clock/test/utils.dart |
| pkgs/coverage/lib/src/coverage_options.dart |
| pkgs/html/example/main.dart |
| pkgs/html/lib/dom.dart |
| pkgs/html/lib/dom_parsing.dart |
| pkgs/html/lib/html_escape.dart |
| pkgs/html/lib/parser.dart |
| pkgs/html/lib/src/constants.dart |
| pkgs/html/lib/src/encoding_parser.dart |
| pkgs/html/lib/src/html_input_stream.dart |
| pkgs/html/lib/src/list_proxy.dart |
| pkgs/html/lib/src/query_selector.dart |
| pkgs/html/lib/src/token.dart |
| pkgs/html/lib/src/tokenizer.dart |
| pkgs/html/lib/src/treebuilder.dart |
| pkgs/html/lib/src/utils.dart |
| pkgs/html/test/dom_test.dart |
| pkgs/html/test/parser_feature_test.dart |
| pkgs/html/test/parser_test.dart |
| pkgs/html/test/query_selector_test.dart |
| pkgs/html/test/selectors/level1_baseline_test.dart |
| pkgs/html/test/selectors/level1_lib.dart |
| pkgs/html/test/selectors/selectors.dart |
| pkgs/html/test/support.dart |
| pkgs/html/test/tokenizer_test.dart |
| pkgs/html/test/trie_test.dart |
| pkgs/html/tool/generate_trie.dart |
| pkgs/pubspec_parse/test/git_uri_test.dart |
| pkgs/stack_trace/example/example.dart |
| pkgs/watcher/test/custom_watcher_factory_test.dart |
| pkgs/yaml_edit/example/example.dart |
This check can be disabled by tagging the PR with skip-license-check.
97b679e to
5df05f1
Compare
5df05f1 to
9a69920
Compare
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/98d03ad..6d1aa6f): 6d1aa6f5 2025-10-23 Sam Rawlins Refactor Locatable into an interface, HasLocation (dart-lang/dartdoc#4118) f82cd35d 2025-10-23 Sam Rawlins Remove unused extension method, replaced in analyzer 8.4.0 (dart-lang/dartdoc#4119) protobuf (https://github.com/dart-lang/protobuf/compare/78cf743..7db0784): 7db0784 2025-10-24 Ömer Sinan Ağacan Avoid redundant nullability checks when updating repeated fields (google/protobuf.dart#1069) a77f9a6 2025-10-23 Ömer Sinan Ağacan More field validation tests (google/protobuf.dart#1068) 27730db 2025-10-21 Ömer Sinan Ağacan Move PbMap to its own library (google/protobuf.dart#1066) 9b4c46f 2025-10-21 Ömer Sinan Ağacan More clearExtension tests: (google/protobuf.dart#1064) 5a44489 2025-10-21 Ömer Sinan Ağacan Move PbList to its own library (google/protobuf.dart#1063) test (https://github.com/dart-lang/test/compare/8083c8f..5855358): 58553580 2025-10-24 Nate Bosch Add a sentence to clarify "Platform" (dart-lang/test#2550) tools (https://github.com/dart-lang/tools/compare/5fe6ee6..e0cc0bc): e0cc0bcc 2025-10-27 Morgan :) Test DirectoryWatcher exception on missing path. (dart-lang/tools#2224) e6ce99da 2025-10-24 Morgan :) Test new link to directory races, fix for them (dart-lang/tools#2223) 9053fae7 2025-10-24 Morgan :) Check file sizes as well as "last modified" times. (dart-lang/tools#2221) Change-Id: Ica6937ba0af21c5ba435e97bd0673fbe7b3043cc Tested: update test goldens Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/457800 Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Improve tests so they cover the race between the OS and the VM when a link to a directory is created.
dart-lang/sdk#61797
This causes multiple tests to start failing. Fix them :) by checking the actual filesystem type for "createDirectory" events.