Modify lint ignores in package:web #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dart-lang#479 Now that we have a general purpose IDL->interop generator, we need to add ignores for constant_identifier_names and non_constant_identifier_names in every output file. unintended_html_in_doc_comment no longer applies as the original reason for it has been fixed. Removes the two lints from analysis_options.yaml as it would now be redundant.
kevmoo
approved these changes
Oct 30, 2025
Member
kevmoo
left a comment
kevmoo
left a comment
There was a problem hiding this comment.
LGTM. Good luck w/ the CI weirdness. 😄
Contributor
Author
Looks like CI was broken already alas. I updated the analyzer dependency but we're forced to ignore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #479
Now that we have a general purpose IDL->interop generator, we need to add ignores for constant_identifier_names and non_constant_identifier_names in every output file. unintended_html_in_doc_comment no longer applies as the original reason for it has been fixed.
Removes the two lints from analysis_options.yaml as it would now be redundant.