Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the SDK constraint to ^3.10.0 across the project and removes the dependency on dart_style, opting to use the dart format command instead. The reviewer identified that the hardcoded language versions in the generator tools were set to 3.6.0 instead of the updated 3.10.0, which could lead to incorrect code generation.
Move pkg:web to Dart 3.10 and regenerate Move pkg:js_interop to Dart 3.10
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the minimum SDK requirement to version 3.10.0 across the project and applies extensive formatting updates to the generated DOM bindings. The generator logic was also updated to reference this specific SDK version. Feedback focuses on improving the robustness of the test suite, specifically addressing potential staleness in the new compilation throttling logic and the use of brittle relative file paths in SDK version validation tests.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the minimum supported Dart SDK version to 3.10.0 across the package and its generator. It introduces a centralized sdkVersion constant in the generator and adds a corresponding test to ensure alignment with pubspec.yaml. Additionally, the PR includes extensive automated formatting updates across the DOM binding files and improves the build infrastructure by refining the compilation check logic for generated bindings. I have no feedback to provide.
srujzs
left a comment
There was a problem hiding this comment.
Nice, thanks for the cleanup!
Move pkg:web to Dart 3.10 and regenerate
Move pkg:js_interop to Dart 3.10
Setup to only compile and run
npm installat most once per test run.