Skip to content

Update min SDKs, regenerate#526

Merged
kevmoo merged 4 commits into
mainfrom
rebuild
Apr 13, 2026
Merged

Update min SDKs, regenerate#526
kevmoo merged 4 commits into
mainfrom
rebuild

Conversation

@kevmoo
Copy link
Copy Markdown
Member

@kevmoo kevmoo commented Apr 6, 2026

Move pkg:web to Dart 3.10 and regenerate
Move pkg:js_interop to Dart 3.10
Setup to only compile and run npm install at most once per test run.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SDK constraint to ^3.10.0 across the project and removes the dependency on dart_style, opting to use the dart format command instead. The reviewer identified that the hardcoded language versions in the generator tools were set to 3.6.0 instead of the updated 3.10.0, which could lead to incorrect code generation.

Comment thread web_generator/bin/update_idl_bindings.dart Outdated
Comment thread web_generator/lib/src/config.dart Outdated
Comment thread web_generator/lib/src/dart_main.dart Outdated
Move pkg:web to Dart 3.10 and regenerate
Move pkg:js_interop to Dart 3.10
@kevmoo kevmoo changed the title Move formatting to use the CLI Update min SDKs, regenerate Apr 7, 2026
@kevmoo
Copy link
Copy Markdown
Member Author

kevmoo commented Apr 7, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum SDK requirement to version 3.10.0 across the project and applies extensive formatting updates to the generated DOM bindings. The generator logic was also updated to reference this specific SDK version. Feedback focuses on improving the robustness of the test suite, specifically addressing potential staleness in the new compilation throttling logic and the use of brittle relative file paths in SDK version validation tests.

Comment thread web_generator/test/test_shared.dart Outdated
Comment thread web_generator/test/sdk_version_test.dart Outdated
@kevmoo
Copy link
Copy Markdown
Member Author

kevmoo commented Apr 7, 2026

/gemini review

@kevmoo kevmoo requested a review from srujzs April 7, 2026 06:07
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum supported Dart SDK version to 3.10.0 across the package and its generator. It introduces a centralized sdkVersion constant in the generator and adds a corresponding test to ensure alignment with pubspec.yaml. Additionally, the PR includes extensive automated formatting updates across the DOM binding files and improves the build infrastructure by refining the compilation check logic for generated bindings. I have no feedback to provide.

Copy link
Copy Markdown
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the cleanup!

Comment thread web_generator/test/sdk_version_test.dart Outdated
@kevmoo kevmoo merged commit 15599ee into main Apr 13, 2026
29 checks passed
@kevmoo kevmoo deleted the rebuild branch April 13, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants