Add check for new JS object representation #1360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debugger filters out native JS objects using the classRef's name. Since DDC will change this representation, we need to check for the new representation.
srujzs
commented
Jul 21, 2021
| (instanceRef?.classRef?.name == 'JavaScriptObject' && | ||
| instanceRef?.classRef?.library?.uri == 'dart:_interceptors') || | ||
| // Old type representation still needed to support older SDK versions. | ||
| instanceRef?.classRef?.name == 'NativeJavaScriptObject'; |
Contributor
Author
There was a problem hiding this comment.
Note that we don't have a library for the previous type representation (NativeJavaScriptObject) since it's part of the DDC runtime, so I left it as is.
Contributor
There was a problem hiding this comment.
yeah the library in the old representation showed as "null" :)
annagrin
approved these changes
Jul 21, 2021
| (instanceRef?.classRef?.name == 'JavaScriptObject' && | ||
| instanceRef?.classRef?.library?.uri == 'dart:_interceptors') || | ||
| // Old type representation still needed to support older SDK versions. | ||
| instanceRef?.classRef?.name == 'NativeJavaScriptObject'; |
Contributor
There was a problem hiding this comment.
yeah the library in the old representation showed as "null" :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debugger filters out native JS objects using the classRef's name. Since DDC will change this representation, we need to check for the new representation.
Checked that
Flutter run for web shows no native javascript objects in static scopesucceeds with and without https://dart-review.googlesource.com/c/sdk/+/199600.