Skip to content

Add check for new JS object representation #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Add check for new JS object representation #1360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dwds/lib/src/debugging/debugger.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,10 @@ class Debugger extends Domain {
}

bool _isNativeJsObject(vm_service.InstanceRef instanceRef) =>
// New type representation of JS objects reifies them to JavaScriptObject.
(instanceRef?.classRef?.name == 'JavaScriptObject' &&
instanceRef?.classRef?.library?.uri == 'dart:_interceptors') ||
// Old type representation still needed to support older SDK versions.
instanceRef?.classRef?.name == 'NativeJavaScriptObject';
Copy link
Contributor Author

@srujzs srujzs Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we don't have a library for the previous type representation (NativeJavaScriptObject) since it's part of the DDC runtime, so I left it as is.

Copy link
Contributor

@annagrin annagrin Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the library in the old representation showed as "null" :)


Future<BoundVariable> _boundVariable(Property property) async {
Expand Down