Migrate some dwds files to null safety #1635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 31, 2022 13:50
annagrin
commented
Jun 3, 2022
nshahan
reviewed
Jun 3, 2022
grouma
reviewed
Jun 6, 2022
elliette
reviewed
Jun 6, 2022
elliette
reviewed
Jun 6, 2022
elliette
reviewed
Jun 6, 2022
elliette
reviewed
Jun 6, 2022
elliette
reviewed
Jun 6, 2022
added 2 commits
June 7, 2022 12:00
annagrin
commented
Jun 8, 2022
Contributor
Author
annagrin
left a comment
annagrin
left a comment
There was a problem hiding this comment.
Thank everyone for very useful comments! Addressed them.
elliette
reviewed
Jun 9, 2022
elliette
reviewed
Jun 9, 2022
nshahan
approved these changes
Jun 9, 2022
Contributor
nshahan
left a comment
nshahan
left a comment
There was a problem hiding this comment.
LGTM with the pending comments.
grouma
approved these changes
Jun 10, 2022
elliette
approved these changes
Jun 10, 2022
Contributor
elliette
left a comment
elliette
left a comment
There was a problem hiding this comment.
LGTM once pending comments are addressed
added 2 commits
June 13, 2022 10:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpressionCompilerandAssetReaderinterfaces so they can be imported separately fromdwds.dartpackage:frontend_server_commonthat would be migrated to null safety next.Towards: #1327