Skip to content

Remove unset clientFuture #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

Remove unset clientFuture #2718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dwds/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## 26.2.3-wip

- Bump `build_web_compilers` to ^4.4.1.
- Remove unused `clientFuture` arg from `DwdsVmClient` methods.

## 26.2.2

Expand Down
10 changes: 1 addition & 9 deletions dwds/lib/src/dwds_vm_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,12 @@ abstract base class DwdsVmClient<
required Stream<VmRequest> requestStream,
required StreamSink<VmRequest> requestSink,
DwdsStats? dwdsStats,
Future<VmService>? clientFuture,
}) {
responseStream.listen((request) async {
final response = await _maybeHandleServiceExtensionRequest(
request,
proxyService: proxyService,
dwdsStats: dwdsStats,
clientFuture: clientFuture,
);
if (response != null) {
requestSink.add(response);
Expand Down Expand Up @@ -169,13 +167,11 @@ abstract base class DwdsVmClient<
VmResponse request, {
required T proxyService,
required DwdsStats? dwdsStats,
required Future<VmService>? clientFuture,
}) async {
final response = await maybeHandleServiceExtensionRequestImpl(
request,
proxyService: proxyService,
dwdsStats: dwdsStats,
clientFuture: clientFuture,
);
if (response != null) {
response['id'] = request['id'] as String;
Expand All @@ -192,7 +188,6 @@ abstract base class DwdsVmClient<
VmResponse request, {
required T proxyService,
DwdsStats? dwdsStats,
Future<VmService>? clientFuture,
});

@mustBeOverridden
Expand Down Expand Up @@ -351,7 +346,6 @@ final class ChromeDwdsVmClient
VmResponse request, {
required ChromeProxyService proxyService,
DwdsStats? dwdsStats,
Future<VmService>? clientFuture,
}) async {
VmRequest? response;
final method = request['method'];
Expand All @@ -362,8 +356,7 @@ final class ChromeDwdsVmClient
} else if (method == _NamespacedServiceExtension.extDwdsReload.method) {
response = await _extDwdsReloadHandler(proxyService);
} else if (method == _NamespacedServiceExtension.extDwdsRestart.method) {
final client = await clientFuture;
response = await _extDwdsRestartHandler(proxyService, client!);
response = await _extDwdsRestartHandler(proxyService, client);
} else if (method == _NamespacedServiceExtension.extDwdsSendEvent.method) {
response = await extDwdsSendEventHandler(request, dwdsStats, logger);
} else if (method == _NamespacedServiceExtension.extDwdsScreenshot.method) {
Expand Down Expand Up @@ -638,7 +631,6 @@ final class WebSocketDwdsVmClient
VmResponse request, {
required WebSocketProxyService proxyService,
DwdsStats? dwdsStats,
Future<void>? clientFuture,
}) async {
VmRequest? response;
final method = request['method'];
Expand Down