[DWDS] Sync changes - Migrate DWDS, test_common, fixtures and fronend_server_common packages to the SDK repository

dwds/analysis_options.yaml

@@ -1,12 +1,8 @@
-include: package:analysis_config/analysis_options.yaml
+include: package:dart_flutter_team_lints/analysis_options.yaml
 
 analyzer:
   exclude:
     # Ignore generated files
     - "lib/data/*"
     # Ignore debug extension builds
     - "debug_extension/compiled/*"
-
-linter:
-  rules:
-    - always_use_package_imports

dwds/debug_extension/web/chrome_api.dart

@@ -403,7 +403,10 @@ class NavigationInfo {
 @JS()
 @anonymous
 class Windows {
-  external dynamic create(WindowInfo? createData, Function(WindowObj) callback);
+  external dynamic create(
+    WindowInfo? createData,
+    void Function(WindowObj) callback,
+  );
 
   external OnFocusChangedHandler get onFocusChanged;
 }

dwds/debug_extension/web/cider_connection.dart

@@ -96,12 +96,12 @@ void sendErrorMessageToCider({
 
 void _sendMessageToCider(String json) {
   final message = {'key': _ciderDartMessageKey, 'json': json};
-  _ciderPort!.postMessage(jsify(message));
+  _ciderPort!.postMessage(jsify(message) as Object);
 }
 
 Future<void> _handleMessageFromCider(dynamic message, Port _) async {
-  final key = getProperty(message, 'key');
-  final json = getProperty(message, 'json');
+  final key = getProperty<String?>(message as Object, 'key');
+  final json = getProperty<String?>(message, 'json');
   if (key != _ciderDartMessageKey || json is! String) {
     sendErrorMessageToCider(
       errorType: CiderErrorType.invalidRequest,

dwds/debug_extension/web/copier.dart

@@ -30,7 +30,7 @@ void _handleRuntimeMessages(
   Function sendResponse,
 ) {
   interceptMessage<String>(
-    message: jsRequest,
+    message: jsRequest is String ? jsRequest : null,
     expectedType: MessageType.appId,
     expectedSender: Script.background,
     expectedRecipient: Script.copier,

dwds/debug_extension/web/cross_extension_communication.dart

@@ -76,7 +76,7 @@ void _forwardCommandToChromeDebugger(
       options.method,
       options.commandParams,
       allowInterop(
-        ([result]) => _respondWithChromeResult(result, sendResponse),
+        ([Object? result]) => _respondWithChromeResult(result, sendResponse),
       ),
     );
   } catch (e) {
@@ -110,7 +110,7 @@ void _forwardMessageToAngularDartDevTools(ExternalExtensionMessage message) {
     message,
     // options
     null,
-    allowInterop(([result]) => _checkForErrors(result, message.name)),
+    allowInterop(([Object? result]) => _checkForErrors(result, message.name)),
   );
 }
 

dwds/debug_extension/web/debug_session.dart

@@ -449,7 +449,7 @@ void _forwardDwdsEventToChromeDebugger(
       Debuggee(tabId: tabId),
       message.command,
       js_util.jsify(params),
-      allowInterop(([e]) {
+      allowInterop(([Object? e]) {
         // No arguments indicate that an error occurred.
         if (e == null) {
           client.sink.add(

dwds/debug_extension/web/detector.dart

@@ -98,11 +98,12 @@ void _detectMultipleDartAppsCallback(
 
 bool _isMultipleAppsMutation(dynamic mutation) {
   final isAttributeMutation =
-      hasProperty(mutation, 'type') &&
-      getProperty(mutation, 'type') == 'attributes';
+      hasProperty(mutation as Object, 'type') &&
+      getProperty<String?>(mutation, 'type') == 'attributes';
   if (isAttributeMutation) {
     return hasProperty(mutation, 'attributeName') &&
-        getProperty(mutation, 'attributeName') == _multipleAppsAttribute;
+        getProperty<String?>(mutation, 'attributeName') ==
+            _multipleAppsAttribute;
   }
   return false;
 }

dwds/debug_extension/web/storage.dart

@@ -54,7 +54,7 @@ Future<bool> setStorageObject<T>({
   final completer = Completer<bool>();
   final storageArea = _getStorageArea(type.persistence);
   storageArea.set(
-    jsify(storageObj),
+    jsify(storageObj) as Object,
     allowInterop(() {
       if (callback != null) {
         callback();
@@ -151,8 +151,8 @@ void interceptStorageChange<T>({
     final isExpected = hasProperty(storageObj, expectedStorageKey);
     if (!isExpected) return;
 
-    final objProp = getProperty(storageObj, expectedStorageKey);
-    final json = getProperty(objProp, 'newValue') as String?;
+    final objProp = getProperty<Object?>(storageObj, expectedStorageKey);
+    final json = getProperty(objProp as Object, 'newValue') as String?;
     T? decodedObj;
     if (json == null || T == String) {
       decodedObj = json as T?;

dwds/debug_extension/web/utils.dart

@@ -124,7 +124,7 @@ final bool isDevMode = () {
 final bool isMV3 = () {
   final extensionManifest = chrome.runtime.getManifest();
   final manifestVersion =
-      getProperty(extensionManifest, 'manifest_version') ?? 2;
+      getProperty<int?>(extensionManifest, 'manifest_version') ?? 2;
   return manifestVersion == 3;
 }();
 

dwds/debug_extension/web/web_api.dart

@@ -32,7 +32,7 @@ external Object _nativeJsFetch(String resourceUrl, FetchOptions options);
 Future<FetchResponse> fetchRequest(String resourceUrl) async {
   try {
     final options = FetchOptions(method: 'GET', credentials: 'include');
-    final response = await promiseToFuture(
+    final response = await promiseToFuture<Object>(
       _nativeJsFetch(resourceUrl, options),
     );
     final body = await promiseToFuture<String?>(

dwds/lib/dart_web_debug_service.dart

@@ -4,22 +4,23 @@
 
 import 'dart:async';
 
-import 'package:dwds/data/build_result.dart';
-import 'package:dwds/src/config/tool_configuration.dart';
-import 'package:dwds/src/connections/app_connection.dart';
-import 'package:dwds/src/connections/debug_connection.dart';
-import 'package:dwds/src/events.dart';
-import 'package:dwds/src/handlers/dev_handler.dart';
-import 'package:dwds/src/handlers/injector.dart';
-import 'package:dwds/src/handlers/socket_connections.dart';
-import 'package:dwds/src/readers/asset_reader.dart';
-import 'package:dwds/src/servers/devtools.dart';
-import 'package:dwds/src/servers/extension_backend.dart';
 import 'package:logging/logging.dart';
 import 'package:shelf/shelf.dart';
 import 'package:sse/server/sse_handler.dart';
 import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';
 
+import 'data/build_result.dart';
+import 'src/config/tool_configuration.dart';
+import 'src/connections/app_connection.dart';
+import 'src/connections/debug_connection.dart';
+import 'src/events.dart';
+import 'src/handlers/dev_handler.dart';
+import 'src/handlers/injector.dart';
+import 'src/handlers/socket_connections.dart';
+import 'src/readers/asset_reader.dart';
+import 'src/servers/devtools.dart';
+import 'src/servers/extension_backend.dart';
+
 typedef ConnectionProvider = Future<ChromeConnection> Function();
 
 /// The Dart Web Debug Service.
@@ -145,8 +146,9 @@ class Dwds {
       debugSettings.expressionCompiler,
       injected,
       DartDevelopmentServiceConfiguration(
-        // This technically isn't correct, but DartDevelopmentServiceConfiguration.enable
-        // is true by default, so this won't break unmigrated tools.
+        // This technically isn't correct, but
+        // DartDevelopmentServiceConfiguration.enable is true by default,
+        // so this won't break unmigrated tools.
         // ignore: deprecated_member_use_from_same_package
         enable: debugSettings.spawnDds && debugSettings.ddsConfiguration.enable,
         // ignore: deprecated_member_use_from_same_package

dwds/lib/dwds.dart

@@ -2,19 +2,19 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-export 'dart_web_debug_service.dart' show Dwds, ConnectionProvider;
+export 'dart_web_debug_service.dart' show ConnectionProvider, Dwds;
 export 'src/config/tool_configuration.dart'
     show
         AppMetadata,
-        UrlEncoder,
         DartDevelopmentServiceConfiguration,
-        DevToolsLauncher,
         DebugSettings,
-        ToolConfiguration;
+        DevToolsLauncher,
+        ToolConfiguration,
+        UrlEncoder;
 export 'src/connections/app_connection.dart' show AppConnection;
 export 'src/connections/debug_connection.dart' show DebugConnection;
 export 'src/debugging/metadata/provider.dart'
-    show MetadataProvider, AbsoluteImportUriException;
+    show AbsoluteImportUriException, MetadataProvider;
 export 'src/events.dart' show DwdsEvent;
 export 'src/handlers/dev_handler.dart' show AppConnectionException;
 export 'src/handlers/socket_connections.dart';
@@ -28,7 +28,7 @@ export 'src/loaders/frontend_server_strategy_provider.dart'
         FrontendServerRequireStrategyProvider;
 export 'src/loaders/require.dart' show RequireStrategy;
 export 'src/loaders/strategy.dart'
-    show LoadStrategy, ReloadConfiguration, BuildSettings;
+    show BuildSettings, LoadStrategy, ReloadConfiguration;
 export 'src/readers/asset_reader.dart' show AssetReader, PackageUriMapper;
 export 'src/readers/frontend_server_asset_reader.dart'
     show FrontendServerAssetReader;
@@ -38,12 +38,12 @@ export 'src/services/chrome/chrome_debug_exception.dart'
     show ChromeDebugException;
 export 'src/services/expression_compiler.dart'
     show
+        CompilerOptions,
         ExpressionCompilationResult,
         ExpressionCompiler,
-        ModuleInfo,
-        CompilerOptions;
+        ModuleInfo;
 export 'src/services/expression_compiler_service.dart'
     show ExpressionCompilerService;
 export 'src/utilities/ddc_names.dart';
 export 'src/utilities/sdk_configuration.dart'
-    show SdkLayout, SdkConfiguration, SdkConfigurationProvider;
+    show SdkConfiguration, SdkConfigurationProvider, SdkLayout;

dwds/lib/expression_compiler.dart

@@ -4,8 +4,8 @@
 
 export 'src/services/expression_compiler.dart'
     show
+        CompilerOptions,
         ExpressionCompilationResult,
         ExpressionCompiler,
-        CompilerOptions,
         ModuleFormat,
         ModuleInfo;

dwds/lib/sdk_configuration.dart

@@ -4,7 +4,7 @@
 
 export 'src/utilities/sdk_configuration.dart'
     show
-        SdkLayout,
+        DefaultSdkConfigurationProvider,
         SdkConfiguration,
         SdkConfigurationProvider,
-        DefaultSdkConfigurationProvider;
+        SdkLayout;

dwds/lib/shared/batched_stream.dart

@@ -5,7 +5,7 @@
 import 'dart:async';
 import 'dart:math';
 import 'package:async/async.dart';
-import 'package:dwds/src/utilities/shared.dart';
+import '../src/utilities/shared.dart';
 
 /// Stream controller allowing to batch events.
 class BatchedStreamController<T> {

dwds/lib/src/config/tool_configuration.dart

@@ -2,9 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:dwds/src/loaders/strategy.dart';
-import 'package:dwds/src/servers/devtools.dart';
-import 'package:dwds/src/services/expression_compiler.dart';
+import '../loaders/strategy.dart';
+import '../servers/devtools.dart';
+import '../services/expression_compiler.dart';
 
 /// Configuration about the app, debug settings, and file system.
 ///

dwds/lib/src/connections/app_connection.dart

@@ -5,11 +5,11 @@
 import 'dart:async';
 import 'dart:convert';
 
-import 'package:dwds/data/connect_request.dart';
-import 'package:dwds/data/run_request.dart';
-import 'package:dwds/data/serializers.dart';
-import 'package:dwds/src/handlers/socket_connections.dart';
-import 'package:dwds/src/utilities/shared.dart';
+import '../../data/connect_request.dart';
+import '../../data/run_request.dart';
+import '../../data/serializers.dart';
+import '../handlers/socket_connections.dart';
+import '../utilities/shared.dart';
 
 /// A connection between the application loaded in the browser and DWDS.
 class AppConnection {

dwds/lib/src/connections/debug_connection.dart

@@ -4,17 +4,18 @@
 
 import 'dart:async';
 
-import 'package:dwds/src/services/app_debug_services.dart';
-import 'package:dwds/src/services/chrome/chrome_proxy_service.dart';
 import 'package:vm_service/vm_service.dart';
 
+import '../services/app_debug_services.dart';
+import '../services/chrome/chrome_proxy_service.dart';
+
 /// A debug connection between the application in the browser and DWDS.
 ///
 /// Supports debugging your running application through the Dart VM Service
 /// Protocol.
 class DebugConnection {
   final AppDebugServices _appDebugServices;
-  final _onDoneCompleter = Completer();
+  final _onDoneCompleter = Completer<void>();
 
   /// Null until [close] is called.
   ///

dwds/lib/src/debugging/chrome_inspector.dart

@@ -4,29 +4,30 @@
 
 import 'dart:math' as math;
 
-import 'package:dwds/src/config/tool_configuration.dart';
-import 'package:dwds/src/connections/app_connection.dart';
-import 'package:dwds/src/debugging/classes.dart';
-import 'package:dwds/src/debugging/debugger.dart';
-import 'package:dwds/src/debugging/execution_context.dart';
-import 'package:dwds/src/debugging/inspector.dart';
-import 'package:dwds/src/debugging/instance.dart';
-import 'package:dwds/src/debugging/libraries.dart';
-import 'package:dwds/src/debugging/location.dart';
-import 'package:dwds/src/debugging/metadata/provider.dart';
-import 'package:dwds/src/debugging/remote_debugger.dart';
-import 'package:dwds/src/loaders/ddc_library_bundle.dart';
-import 'package:dwds/src/readers/asset_reader.dart';
-import 'package:dwds/src/utilities/conversions.dart';
-import 'package:dwds/src/utilities/dart_uri.dart';
-import 'package:dwds/src/utilities/domain.dart';
-import 'package:dwds/src/utilities/objects.dart';
-import 'package:dwds/src/utilities/server.dart';
-import 'package:dwds/src/utilities/shared.dart';
 import 'package:logging/logging.dart';
 import 'package:vm_service/vm_service.dart';
 import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';
 
+import '../config/tool_configuration.dart';
+import '../connections/app_connection.dart';
+import '../loaders/ddc_library_bundle.dart';
+import '../readers/asset_reader.dart';
+import '../utilities/conversions.dart';
+import '../utilities/dart_uri.dart';
+import '../utilities/domain.dart';
+import '../utilities/objects.dart';
+import '../utilities/server.dart';
+import '../utilities/shared.dart';
+import 'classes.dart';
+import 'debugger.dart';
+import 'execution_context.dart';
+import 'inspector.dart';
+import 'instance.dart';
+import 'libraries.dart';
+import 'location.dart';
+import 'metadata/provider.dart';
+import 'remote_debugger.dart';
+
 /// An inspector for a running Dart application contained in the
 /// [WipConnection].
 ///

dwds/lib/src/debugging/classes.dart

@@ -2,14 +2,15 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:dwds/src/config/tool_configuration.dart';
-import 'package:dwds/src/debugging/chrome_inspector.dart';
-import 'package:dwds/src/debugging/metadata/class.dart';
-import 'package:dwds/src/services/chrome/chrome_debug_exception.dart';
-import 'package:dwds/src/utilities/shared.dart';
 import 'package:vm_service/vm_service.dart';
 import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';
 
+import '../config/tool_configuration.dart';
+import '../services/chrome/chrome_debug_exception.dart';
+import '../utilities/shared.dart';
+import 'chrome_inspector.dart';
+import 'metadata/class.dart';
+
 /// Keeps track of Dart classes available in the running application.
 class ChromeAppClassHelper {
   /// Map of class ID to [Class].