return an error code for hot reload #299
Conversation
| throw ArgumentError.value( | ||
| fullRestart, 'fullRestart', 'We do not support hot reload yet.'); | ||
| return { | ||
| 'code': 1, |
There was a problem hiding this comment.
The code -32601 is standardized in the JSON RPC spec to mean "Method not found". Should we use that here?
There was a problem hiding this comment.
The method is found just not implemented so I don't think that makes sense here.
There was a problem hiding this comment.
https://www.jsonrpc.org/specification#error_object
The meaning is "The method does not exist / is not available." - IMO "not available" applies here.
There was a problem hiding this comment.
Ahh. Makes more sense to me then.
There was a problem hiding this comment.
It's not spec'd in the daemon protocol what non-zero codes look like. Clients are written to use 0 to mean success, and non-zero failure. The only other daemon protocol impl (in flutter_tools) uses 1 for a restart failed code.
3 participants
In IDEs, we can show:
instead of:
I'm going to let this build through in the bots - I'm having trouble running the tests locally.