Skip to content

Log messages through daemon.log #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grouma merged 3 commits into from
Apr 19, 2019
Merged

Log messages through daemon.log #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ff17aa
Log messages through daemon.log
grouma Apr 19, 2019
54ad84c
Merge branch 'master' into daemon-log
grouma Apr 19, 2019
566dbb4
build
grouma Apr 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions webdev/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.0.0-dev

- The daemon command now logs build events through `daemon.log`.

## 2.0.0-alpha.4

- Fix an NPE is the reload logic.
Expand Down
4 changes: 2 additions & 2 deletions webdev/lib/src/command/daemon_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ class DaemonCommand extends Command<int> {
daemon = Daemon(_stdinCommandStream, _stdoutCommandResponse);
var daemonDomain = DaemonDomain(daemon);
setLogHandler((level, message, {verbose}) {
daemonDomain.sendEvent(
'daemon.logMessage', {'level': '$level', 'message': message});
daemonDomain
.sendEvent('daemon.log', {'level': '$level', 'message': message});
});
daemon.registerDomain(daemonDomain);
var configuration =
Expand Down
2 changes: 1 addition & 1 deletion webdev/lib/src/version.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion webdev/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: webdev
version: 2.0.0-alpha.4
version: 2.0.0-dev
author: Dart Team <misc@dartlang.org>
homepage: https://github.com/dart-lang/webdev
description: >-
Expand Down