Cleanup tests #490
Merged
Cleanup tests #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Jul 15, 2019
| await client.registerService('fullReload', 'DWDS'); | ||
|
|
||
| client.registerServiceCallback('ext.webdev.screenshot', (_) async { | ||
| client.registerServiceCallback('ext.dwds.screenshot', (_) async { |
Contributor
There was a problem hiding this comment.
cc @jonahwilliams not sure if you were using this yet
Contributor
There was a problem hiding this comment.
Haven't landed anything yet, so no issues here
| @@ -1,60 +0,0 @@ | |||
| // Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file | |||
Member
Author
There was a problem hiding this comment.
It was moved over to package:dwds. No need to test from webdev.
Contributor
There was a problem hiding this comment.
I don't see a test in dwds though (would have expected this to be a move?)
Member
Author
There was a problem hiding this comment.
Ahh good catch. Didn't include it in my commit.
jakemac53
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #475