fix: docker-test-suite missing test files#338
Merged
Conversation
strophy
force-pushed
the
fix/docker-test-suite
branch
from
da291d3 to
a936152
Compare
strophy
force-pushed
the
fix/docker-test-suite
branch
from
a936152 to
152464d
Compare
markin-io
changed the title
Collaborator
|
@strophy I see this is tagged v0.23, but was merged into master? Maybe the milestone should be removed/changed. 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
docker run --rm -v ~/.env:/platform/packages/platform-test-suite/.env dashpay/platform-test-suite:0.22.1 yarn test:suitethrows:
Warning: Cannot find any files matching pattern "./test/**/*.spec.js"And tests do not run
What was done?
This is caused by the
.dockerignorefile ignoringpackages/*/testwhich incorrectly includes the tests which platform test suite needs to run. This was fixed by adding an exclusion rule.How Has This Been Tested?
Tested in local builds
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only