Skip to content

ci: add latest-dev docker tag#382

Merged
strophy merged 2 commits into
v0.23-devfrom
add-latest-dev-docker-tag
May 10, 2022
Merged

ci: add latest-dev docker tag#382
strophy merged 2 commits into
v0.23-devfrom
add-latest-dev-docker-tag

Conversation

@strophy
Copy link
Copy Markdown
Collaborator

@strophy strophy commented May 9, 2022

Issue being fixed or feature implemented

In order to run test suite against both testnet and devnets in CI from a single repo, it is necessary to use a matrix strategy to select a test suite image version to match the version running on the networks. To avoid hard coding the version for devnets, we need to add latest-dev to the list of Docker tags generated by the metadata action.

What was done?

  • Bump metadata action version
  • Always emit latest tag and apply suffix

How Has This Been Tested?

Tested in Github Actions from strophy/platform repo. Example outputs:
Input: v0.23.0-dev.6

  dashpay/platform-test-suite:0-dev
  dashpay/platform-test-suite:0.23-dev
  dashpay/platform-test-suite:0.23.0-dev
  dashpay/platform-test-suite:0.23.0-dev.6
  dashpay/platform-test-suite:latest-dev

Input: v0.23.1

  dashpay/platform-test-suite:0
  dashpay/platform-test-suite:0.23
  dashpay/platform-test-suite:0.23.1
  dashpay/platform-test-suite:latest

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy added this to the v0.23.0 milestone May 9, 2022
@strophy strophy requested review from antouhou and shumkov as code owners May 9, 2022 07:43
@strophy strophy requested a review from jaboski May 9, 2022 07:43
@jaboski
Copy link
Copy Markdown
Contributor

jaboski commented May 9, 2022

I reran platform test suite which passed in second execution

Copy link
Copy Markdown
Contributor

@jaboski jaboski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants