Skip to content

$sort() comparator violates Java Comparator contract, causing TimSort failure with equal values #99

@85C77EF3-E4C7-4251-A987-02CB8DD42971

Description

Description:

The $sort() function's comparator wrapper maps boolean results incorrectly, violating Java's Comparator contract. This causes TimSort to throw "Comparison method violates its general contract!" when the array contains equal values.

Reproduction:

$sort([
    {"v":0},{"v":0},{"v":0},{"v":0},{"v":0},{"v":0},{"v":0},{"v":0}, 
    {"v":1},
    {"v":0},{"v":0},{"v":0},{"v":0},{"v":0},{"v":0},{"v":0},
    {"v":2},
    {"v":0},{"v":0},{"v":0},{"v":0},{"v":0},{"v":0},{"v":0},{"v":0},
    {"v":0},{"v":0},{"v":0},{"v":0},{"v":0},{"v":0},{"v":0},
    {"v":3} 
], function($a, $b) { $a.v > $b.v })

Result:

java.lang.IllegalArgumentException: Comparison method violates its general contract!
  at java.util.TimSort.mergeLo(TimSort.java:781)
  at java.util.TimSort.mergeAt(TimSort.java:518)
  at java.util.TimSort.mergeForceCollapse(TimSort.java:461)
  at java.util.TimSort.sort(TimSort.java:254)
  at java.util.Arrays.sort(Arrays.java:1233)
  at java.util.ArrayList.sort(ArrayList.java:1721)
  at com.dashjoin.jsonata.Functions.sort(Functions.java:1979)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions