Conversation
✅ Deploy Preview for strchive ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
@Macayla-weiner would you like to try adding to this PR by editing the CPUM branch within the dashnowlab repository? There are still a few suggestions left from here #204 (review) |
Macayla-weiner
approved these changes
Jun 30, 2025
Change the representation of MUC1 from a homopolymer expansion to a VNTR motif switch Fixes: # **Link to any relevant issues and/or discussions** - Change the representation of MUC1 from a homopolymer expansion to a VNTR motif switch - Don't plot loci with all missing data in locus plots - [x] All changes are well summarized - [x] Check all tests pass - [x] Check that the website preview looks good - [ ] Update the STRchive version in `CITATION.cff`, format X.Y.Z. If any major changes, increment Y. If only minor changes, increment Z. If the breaking change (rare), increment X. - [x] Ask someone to review this PR --------- Co-authored-by: hdashnow <3794821+hdashnow@users.noreply.github.com>
Member
Author
|
I edited the T2T start coordinate a little so that it starts at the first perfect motif. And rebased against main so it can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the same content as in #204 by @Macayla-weiner, except I've rebased it against main so that it should include a better website preview, including properly formatted references.
Replaces: #204
Fixes: #200
Major Changes
Checklist
CITATION.cff, format X.Y.Z. If any major changes, increment Y. If only minor changes, increment Z. If the breaking change (rare), increment X.