fix: Use getgovernanceinfo in RPC check#310
Merged
Merged
Conversation
nmarley
changed the title
nmarley
added a commit
to nmarley/dash-network-deploy
that referenced
this pull request
Jul 8, 2022
4 tasks
nmarley
added a commit
that referenced
this pull request
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
The
getblockchaininfocall is heavy, consumes a lot of resources. Since we are only using this to check if RPC is ready, we can use something light likegetgovernanceinfoinstead. This saves 2-3 seconds each time it's called.What was done?
Changed
getblockchaininfotogetgovernanceinfoin dashd RPC check.How Has This Been Tested?
I tested this by running the dashd play on a testnet masternode, once.
Breaking Changes
n/a
Checklist: