Skip to content

fix: ip addresses + some cleanup + add some mn bindings#113

Merged
pankcuf merged 3 commits intodevelopfrom
fix/masternode-ip-addresses
Apr 22, 2025
Merged

fix: ip addresses + some cleanup + add some mn bindings#113
pankcuf merged 3 commits intodevelopfrom
fix/masternode-ip-addresses

Conversation

@pankcuf
Copy link
Copy Markdown
Contributor

@pankcuf pankcuf commented Apr 8, 2025

This pull request updates the dash-spv-apple-bindings project by modernizing dependencies, improving compatibility, and simplifying the codebase. Key changes include dependency upgrades, feature enhancements, and the removal of unused or redundant code.

Dependency Updates and Feature Enhancements:

  • Updated dependencies in Cargo.toml, including anyhow, indexmap, and ferment to newer versions for better compatibility and stability. The grovedb-version dependency now points to a specific Git revision. Added new features like message_verification and quorum_validation to the default feature set. [1] [2] [3] [4]
  • Increased the iOS deployment target from 12.0 to 14.0 in Cargo.toml for better alignment with modern iOS versions.

Code Simplifications:

  • Removed unused methods and fields from FFICoreProvider in ffi_core_provider.rs, such as get_cl_signature_by_block_hash and notify_sync_state. Simplified the implementation of MasternodeProcessor initialization. [1] [2] [3] [4]
  • Cleaned up unused imports and redundant code in lib.rs, including the removal of the DiffConfig struct and unused error types. [1] [2] [3] [4] [5]

Build and Configuration Improvements:

  • Updated build.sh to fix paths for verification scripts and commented out logging configuration for RUSTC_LOG. [1] [2]
  • Added a new feature mapping (quorum_validation) in cbindgen.toml for code generation. Removed outdated and unused configuration options.

Test Code Cleanup:

  • Removed legacy test utilities and functions, such as get_block_from_insight_by_hash and register_logger, from common.rs to streamline the test codebase. [1] [2]

Miscellaneous:

  • Removed the cbindgen crate from build.rs as it is no longer used.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pankcuf pankcuf marked this pull request as ready for review April 22, 2025 06:20
@pankcuf pankcuf requested a review from Syn-McJ April 22, 2025 06:21
Copy link
Copy Markdown
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I still can't build with build.sh:

error[E0107]: struct takes 3 generic arguments but 2 generic arguments were supplied
  --> /Users/andrei/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tower-0.4.13/src/ready_cache/cache.rs:73:12
   |
73 |     ready: IndexMap<K, (S, CancelPair)>,
   |            ^^^^^^^^ -  --------------- supplied 2 generic arguments
   |            |
   |            expected 3 generic arguments
   |
note: struct defined here, with 3 generic parameters: `K`, `V`, `S`

@pankcuf pankcuf merged commit 7005c26 into develop Apr 22, 2025
2 of 3 checks passed
@pankcuf pankcuf deleted the fix/masternode-ip-addresses branch April 23, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants