Merge bitcoin#11073: Remove dead store in ecdsa_signature_parse_der_lax.

laanwj · PastaPastaPasta · commit df109ec1186c · 2020-01-12T17:01:40.000-06:00
bfebc0b Remove dead store in ecdsa_signature_parse_der_lax. (Eelis) Pull request description: This was one of the issues found by Clang's static analyzer (bitcoin#9573). Tree-SHA512: 3674c56ccdc750bfe42e41d56b1f2058b6921c5354f7e757f6af10a759c5be75e23d6c7932a4524b9a24da308f426803b11deffbfcf09a5898a4204ee61d16d2
diff --git a/src/pubkey.cpp b/src/pubkey.cpp
@@ -126,7 +126,6 @@ static int ecdsa_signature_parse_der_lax(const secp256k1_context* ctx, secp256k1
         return 0;
     }
     spos = pos;
-    pos += slen;
 
     /* Ignore leading zeroes in R */
     while (rlen > 0 && input[rpos] == 0) {

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,6 @@ static int ecdsa_signature_parse_der_lax(const secp256k1_context* ctx, secp256k1`
`126`	`126`	`return 0;`
`127`	`127`	`}`
`128`	`128`	`spos = pos;`
`129`		`- pos += slen;`
`130`	`129`
`131`	`130`	`/* Ignore leading zeroes in R */`
`132`	`131`	`while (rlen > 0 && input[rpos] == 0) {`