No need for zero initialization of devnet params

codablock · PastaPastaPasta · commit e740604f608a · 2019-06-26T12:45:10.000-05:00
diff --git a/src/chainparams.cpp b/src/chainparams.cpp
@@ -871,12 +871,6 @@ std::unique_ptr<CChainParams> CreateChainParams(const std::string& chain)
 
 void SelectParams(const std::string& network)
 {
-    if (network == CBaseChainParams::DEVNET) {
-        devNetParams = (CDevNetParams*)new uint8_t[sizeof(CDevNetParams)];
-        memset(devNetParams, 0, sizeof(CDevNetParams));
-        new (devNetParams) CDevNetParams();
-    }
-
     SelectBaseParams(network);
     globalChainParams = CreateChainParams(network);
 }

Original file line number	Diff line number	Diff line change
`@@ -871,12 +871,6 @@ std::unique_ptr<CChainParams> CreateChainParams(const std::string& chain)`
`871`	`871`
`872`	`872`	`void SelectParams(const std::string& network)`
`873`	`873`	`{`
`874`		`- if (network == CBaseChainParams::DEVNET) {`
`875`		`- devNetParams = (CDevNetParams*)new uint8_t[sizeof(CDevNetParams)];`
`876`		`- memset(devNetParams, 0, sizeof(CDevNetParams));`
`877`		`- new (devNetParams) CDevNetParams();`
`878`		`- }`
`879`		`-`
`880`	`874`	`SelectBaseParams(network);`
`881`	`875`	`globalChainParams = CreateChainParams(network);`
`882`	`876`	`}`