Skip to content

Commit f84d5d4

Browse files
AmirAbramsUdjinM6
authored andcommitted
QT: Revert "Force TLS1.0+ for SSL connections" (#2985)
See: bitcoin@0242b5a This reverts commit 15e26a6, whose purpose was to tweak the Qt configuration to force TLS, i.e., to disable SSLv3, in Qt versions >= 5.5. However, the default behavior of Qt >= 5.4 is to disable SSLv3 anyway [1], so the configuration tweak is redundant. With Qt 5.11.2, the configuration tweak is not only redundant but in fact provokes a deadlock (bitcoin#14359) due to Qt 5.11.2 being incompatible with OpenSSL 1.1.1 [2]. Since the deadlock occurs at the early startup stage of bitcoin-qt, it renders bitcoin-qt entirely non-functional when compiled against OpenSSL 1.1.1 and Qt 5.11.2 (and possible future combinations of OpenSSL and Qt versions). This commit fixes bitcoin#14359 by removing the redundant code. [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=3fd2d9eff8c1f948306ee5fbfe364ccded1c4b84 [2] https://bugreports.qt.io/browse/QTBUG-70956
1 parent 2e13d13 commit f84d5d4

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

src/qt/dash.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@
5454
#include <QThread>
5555
#include <QTimer>
5656
#include <QTranslator>
57-
#include <QSslConfiguration>
5857

5958
#if defined(QT_STATICPLUGIN)
6059
#include <QtPlugin>
@@ -601,13 +600,6 @@ int main(int argc, char *argv[])
601600
#ifdef Q_OS_MAC
602601
QApplication::setAttribute(Qt::AA_DontShowIconsInMenus);
603602
#endif
604-
#if QT_VERSION >= 0x050500
605-
// Because of the POODLE attack it is recommended to disable SSLv3 (https://disablessl3.com/),
606-
// so set SSL protocols to TLS1.0+.
607-
QSslConfiguration sslconf = QSslConfiguration::defaultConfiguration();
608-
sslconf.setProtocol(QSsl::TlsV1_0OrLater);
609-
QSslConfiguration::setDefaultConfiguration(sslconf);
610-
#endif
611603

612604
// Register meta types used for QMetaObject::invokeMethod
613605
qRegisterMetaType< bool* >();

0 commit comments

Comments
 (0)