chore: disable contested usernames#704
Merged
Syn-McJ merged 5 commits intoMay 28, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates localization strings across all languages to disable contested usernames and enforce non-contested username rules.
- Removed references to contested usernames and related invitation flows.
- Added new validation messages for non-contested usernames (length and numeric requirements).
- Updated user feedback strings to explain blocked usernames and criteria.
| "You can enter your key in any of the following formats: WIF/base58/base64/hex" = "You can enter your key in any of the following formats: WIF/base58/base64/hex"; | ||
|
|
||
| /* Invites */ | ||
| "You can only create a non-contested username using this invitaiton" = "You can only create a non-contested username using this invitaiton"; |
There was a problem hiding this comment.
Correct the spelling of 'invitaiton' to 'invitation'.
Suggested change
| "You can only create a non-contested username using this invitaiton" = "You can only create a non-contested username using this invitaiton"; | |
| "You can only create a non-contested username using this invitation" = "You can only create a non-contested username using this invitation"; |
Comment on lines
+4
to
+5
| /* Usernames */ | ||
| " of these criteria" = " of these criteria"; |
There was a problem hiding this comment.
[nitpick] Having a standalone key ' of these criteria' is confusing; consider merging it with the full sentence key or using a single key for 'The username must meet these criteria'.
Suggested change
| /* Usernames */ | |
| " of these criteria" = " of these criteria"; | |
| /* Username criteria */ | |
| "The username must meet these criteria" = "The username must meet these criteria"; |
| /* Validation rule: Between 3 and 24 characters */ | ||
| "Between %ld and %ld characters" = "Zwischen %1$ld und %2$ld Zeichen"; | ||
| /* Usernames */ | ||
| "Between 20 and 23 characters" = "Between 20 and 23 characters"; |
There was a problem hiding this comment.
This new validation string is still in English; please provide a German translation.
Suggested change
| "Between 20 and 23 characters" = "Between 20 and 23 characters"; | |
| "Between 20 and 23 characters" = "Zwischen 20 und 23 Zeichen"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We want to disable contested usernames for now
What was done?
How Has This Been Tested?
QA
Breaking Changes
Checklist:
For repository code-owners and collaborators only