Skip to content

feat: custom icon for transactions#707

Merged
Syn-McJ merged 6 commits into
dashpay:feature/dashspendfrom
Syn-McJ:feat/dashspend-save-icon
Jun 12, 2025
Merged

feat: custom icon for transactions#707
Syn-McJ merged 6 commits into
dashpay:feature/dashspendfrom
Syn-McJ:feat/dashspend-save-icon

Conversation

@Syn-McJ
Copy link
Copy Markdown
Member

@Syn-McJ Syn-McJ commented Jun 5, 2025

Issue being fixed or feature implemented

We want to associate an icon with a transaction and potentially synchronize it as transaction metadata with the platform.

What was done?

  • Cherry-pick the tx metadata refactoring from the private note PR.
  • Table for custom icons in the DB.
  • Save the icon data into the DB if not present, and associate its ID with the transaction.
  • Load the icon in the Gift Card details screen.

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf June 5, 2025 13:15
@Syn-McJ Syn-McJ self-assigned this Jun 5, 2025
Copy link
Copy Markdown
Contributor

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit 644884a into dashpay:feature/dashspend Jun 12, 2025
1 check passed
@Syn-McJ Syn-McJ deleted the feat/dashspend-save-icon branch June 12, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants