docs(reference): update query-syntax and DAPI endpoint docs for v3.1#142
docs(reference): update query-syntax and DAPI endpoint docs for v3.1#142thephez merged 4 commits intodashpay:3.1.0from
Conversation
- Remove getProofs section (outdated identities/contracts/documents schema no longer exists in platform.proto; endpoint is internal DAPI-to-Drive only) - Remove getProofs row from endpoint overview table - Fix getEpochsInfo start_epoch parameter type: Bytes → Integer Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… clause changes Add Between/BetweenExclude* operators with examples, clarify where clause is optional, add offset modifier, update startAt/startAfter examples, and fix DPNS index line numbers.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add $createdAtCoreBlockHeight example to system timestamp fields - Document = as alias for == equality operator - Remove incorrect startsWith 255-character limit - Remove incorrect orderBy maximum: 2 constraint - Reorder range-operator tip to lead with normalisation behaviour - Guard doc?.toJSON() in Evo SDK example against undefined Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughDocumentation updates across Dash Platform reference guides: revised Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~18 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
docs/reference/query-syntax.md (2)
142-142: Use a complete sentence in theorderBymodifier description.“Can only be used …” is a sentence fragment in the table text.
✏️ Suggested wording
-| `orderBy` | Returns records sorted by the field(s) provided. Sorting must be by the last indexed property. Can only be used with `>`, `<`, `>=`, `<=`, `Between`, `BetweenExcludeBounds`, `BetweenExcludeLeft`, `BetweenExcludeRight`, and `startsWith` queries. | `orderBy: [['normalizedLabel', 'asc']]` | +| `orderBy` | Returns records sorted by the field(s) provided. Sorting must be by the last indexed property. It can only be used with `>`, `<`, `>=`, `<=`, `Between`, `BetweenExcludeBounds`, `BetweenExcludeLeft`, `BetweenExcludeRight`, and `startsWith` queries. | `orderBy: [['normalizedLabel', 'asc']]` |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/reference/query-syntax.md` at line 142, The table entry for the orderBy modifier contains a sentence fragment; update the description for `orderBy` to be a complete sentence (e.g., start with a subject) and clearly state its constraints and usage, referencing `orderBy` and the allowed query types (`>`, `<`, `>=`, `<=`, `Between`, `BetweenExcludeBounds`, `BetweenExcludeLeft`, `BetweenExcludeRight`, and `startsWith`) so the table cell becomes a full sentence explaining that `orderBy` returns records sorted by the provided field(s) and can only be used with those query types and when sorting by the last indexed property.
66-66: Clarify the range-operator rule to avoid a mixed signal.This line currently reads as both a strict prohibition and an allowed auto-normalization path. Tightening wording will reduce ambiguity for implementers.
✏️ Suggested wording
-- Only one range operator is allowed in a query. `Between` and its variants are single operators that replace a `>=`/`<=` pair — the engine also normalizes two range operators on the same field into the equivalent `Between*` form automatically +- Only one effective range operator is applied per field in a query. If you provide lower/upper bounds on the same field (for example `>=` + `<=`), the engine normalizes them into the equivalent `Between*` form automatically.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/reference/query-syntax.md` at line 66, The current sentence "Only one range operator..." is ambiguous; reword it to state explicitly that a query must not contain more than one explicit range operator on the same field (e.g., you may not supply both >= and > as separate range operators for a single field), and also note that the engine will automatically normalize an equivalent >=/<= pair into the single Between/Between* form for processing; reference the existing phrase "Only one range operator" and the "Between" operator to locate where to replace the sentence so implementers know to accept explicit Between variants and normalized >=/<= pairs but reject multiple explicit range operators on the same field.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/reference/query-syntax.md`:
- Line 142: The table entry for the orderBy modifier contains a sentence
fragment; update the description for `orderBy` to be a complete sentence (e.g.,
start with a subject) and clearly state its constraints and usage, referencing
`orderBy` and the allowed query types (`>`, `<`, `>=`, `<=`, `Between`,
`BetweenExcludeBounds`, `BetweenExcludeLeft`, `BetweenExcludeRight`, and
`startsWith`) so the table cell becomes a full sentence explaining that
`orderBy` returns records sorted by the provided field(s) and can only be used
with those query types and when sorting by the last indexed property.
- Line 66: The current sentence "Only one range operator..." is ambiguous;
reword it to state explicitly that a query must not contain more than one
explicit range operator on the same field (e.g., you may not supply both >= and
> as separate range operators for a single field), and also note that the engine
will automatically normalize an equivalent >=/<= pair into the single
Between/Between* form for processing; reference the existing phrase "Only one
range operator" and the "Between" operator to locate where to replace the
sentence so implementers know to accept explicit Between variants and normalized
>=/<= pairs but reject multiple explicit range operators on the same field.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a28a3ef1-1432-4bfb-bbe8-d874ffb3de87
📒 Files selected for processing (3)
docs/reference/dapi-endpoints-platform-endpoints.mddocs/reference/dapi-endpoints.mddocs/reference/query-syntax.md
💤 Files with no reviewable changes (1)
- docs/reference/dapi-endpoints.md
Updates
query-syntax.mdand DAPI platform endpoint docs to reflect the current v3.1 implementation.What was done?
docs/reference/query-syntax.md$transferredAt,$createdAtBlockHeight, and$createdAtCoreBlockHeightBetween,BetweenExcludeBounds,BetweenExcludeLeft,BetweenExcludeRightoperators to the Range table=as an accepted alias for==startsWith255-character limit (not enforced at the query layer)orderBy"maximum: 2" constraint (no such hard limit exists; effective limit is the matched index's property count)Betweenoperator example tab andoffsetmodifier roworderByoperator list to includeBetween*variantsstartAt/startAfterexamples with plain document ID strings (removedBuffer.from(Identifier.from(...))pattern)doc?.toJSON()to handle potential undefined valuesdocs/reference/dapi-endpoints-platform-endpoints.mdgetProofssection (internal DAPI-to-Drive endpoint; all external requests rejected)start_epochtype:Bytes→Integerdocs/reference/dapi-endpoints.mdgetProofsrow from the endpoint summary tablePreview build: https://dash-docs-platform--142.org.readthedocs.build/en/142/
Summary by CodeRabbit
Between,BetweenExcludeBounds,BetweenExcludeLeft, andBetweenExcludeRight.whereclause optional in queries; omitting it returns all documents.offsetmodifier for query result pagination.