docs(protocol-ref): add shielded pool concept and wire format#150
Conversation
Introduces the Orchard-based shielded pool, its core concepts (notes, nullifiers, anchors, encrypted notes), the 5 shielded transition flows, and the 16-action-per-transition limit. Wired into the Explanations toctree. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
New protocol-ref/shielded-pool.md documents the five shielded state transition types (Shield, Shielded Transfer, Unshield, Shield from Asset Lock, Shielded Withdrawal) along with the shared Orchard bundle primitives, the per-action serialized form, and the Orchard / address witness / asset-lock signature layers that authorize them. Wires the discriminator rows 15-19 in state-transition.md to the new page, adds a Signing Shielded Transitions subsection, and links from the signing-methods table. Fixes the stale max_shielded_transition_actions constant (was 100; correct value is 16) and adds the max_asset_lock_transaction_inputs limit to protocol-constants.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds an "Adding a new doc page" section to CLAUDE.md explaining that new pages must be wired into a Sphinx toctree in docs/index.md and that scripts/sync_sidebar.py needs to run afterwards. Syncs the sidebar so the new explanations/shielded-pool.md and protocol-ref/shielded-pool.md pages appear in the rendered nav. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 46 minutes and 51 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis PR adds comprehensive documentation for Dash Platform v3.1.0, covering a new shielded pool privacy layer, cryptographic proofs verification, aggregate query capabilities for document retrieval, and associated protocol specification updates across explanation pages, protocol references, DAPI documentation, and site navigation. ChangesDash Platform v3.1.0 Documentation Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Summary
docs/explanations/shielded-pool.mdintroducing the Orchard-based shielded pool, the core primitives (notes, nullifiers, anchors, encrypted notes), the five shielded transition flows, and the 16-action-per-transition limit.docs/protocol-ref/shielded-pool.mddocumenting the wire format for all five shielded transitions (Shield, Shielded Transfer, Unshield, Shield from Asset Lock, Shielded Withdrawal), the shared Orchard bundle and per-actionSerializedActionshape, and the layered signing model (per-actionspendAuthSig, transition-levelbindingSignature, platform sighash, plus the transparent signatures on Shield and Shield from Asset Lock).state-transition.mdto the new page, adds aSigning Shielded Transitionssubsection, and lists the shielded family in the signing-methods table.max_shielded_transition_actionsentry inprotocol-constants.md(was100, correct value is16with a corrected source-link anchor) and addsmax_asset_lock_transaction_inputs = 100.Adding a new doc pageblock toCLAUDE.mddocumenting the Sphinx toctree requirement and thesync_sidebar.pystep, plus the synced sidebar so the two new pages appear in the rendered nav.Preview build: https://dash-docs-platform--150.org.readthedocs.build/en/150/
Summary by CodeRabbit
getDocumentsendpoint with aggregate query support (count/sum/average operations).