Skip to content

chore: update rocksdb to version 0.24.0#383

Merged
QuantumExplorer merged 1 commit intodevelopfrom
choreupdate-rocksdb-version
Sep 6, 2025
Merged

chore: update rocksdb to version 0.24.0#383
QuantumExplorer merged 1 commit intodevelopfrom
choreupdate-rocksdb-version

Conversation

@QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Sep 6, 2025

Issue being fixed or feature implemented

Update the rocksdb dependency to the latest version.

What was done?

Updated the rocksdb version in the Cargo.toml file from 0.23.0 to 0.24.0.

How Has This Been Tested?

No specific tests were mentioned, but the update should be validated through existing unit tests.

Breaking Changes

None

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores
    • Upgraded the RocksDB dependency to version 0.24.0.
    • No user-facing changes or UI updates.
    • No configuration or migration required.
    • Existing behavior and workflows remain unchanged.
    • Build and runtime behavior expected to be consistent with previous release.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 6, 2025

Walkthrough

Updates the RocksDB dependency in storage/Cargo.toml from version 0.23.0 to 0.24.0; the optional flag remains unchanged. No code files are modified.

Changes

Cohort / File(s) Summary
Dependency version bump
storage/Cargo.toml
Updated rocksdb from 0.23.0 to 0.24.0; optional = true unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nudge a version, hop and glide,
From .23 to .24 I ride.
No code to tweak, no rocks to shove,
Just Cargo whispers from above.
Carrot raised—ship it with pride!

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch choreupdate-rocksdb-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
storage/Cargo.toml (1)

21-21: Optional: consider jumping to a newer minor (e.g., 0.28.x) to avoid follow-up bumps.

0.28.0 adds features (e.g., blob cache) and tracks RocksDB 9.4.0; if compatible, upgrading now could reduce churn. (docs.rs)

If you want to do it here, the diff is trivial:

- rocksdb = { version = "0.24.0", optional = true }
+ rocksdb = { version = "0.28.0", optional = true }
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 947bc47 and ede1d5b.

📒 Files selected for processing (1)
  • storage/Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Compilation errors
  • GitHub Check: Linting
  • GitHub Check: Code Coverage
  • GitHub Check: Tests
🔇 Additional comments (1)
storage/Cargo.toml (1)

21-21: Unable to auto-validate RocksDB bump
Validation script failed due to missing /proc; please manually run in your local/CI environment:

cargo update -p rocksdb
cargo build -p grovedb-storage --features rocksdb_storage
cargo test  -p grovedb-storage --features rocksdb_storage

to confirm that upgrading rocksdb = "0.24.0" in storage/Cargo.toml introduces no regressions.

@QuantumExplorer QuantumExplorer merged commit 898179d into develop Sep 6, 2025
8 checks passed
@QuantumExplorer QuantumExplorer deleted the choreupdate-rocksdb-version branch September 6, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant