fix/create restore username #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
commented
Mar 24, 2025
Comment on lines
-178
to
+176
| lateinit var registrationFundingPrivateKey: ECKey | ||
| var registrationFundingPrivateKey: ECKey? = null |
Collaborator
Author
There was a problem hiding this comment.
This isn't used, but we can keep it for now. crashes resulted from lateinit
HashEngineering
commented
Mar 24, 2025
Comment on lines
+447
to
+455
| val coreHeight = if (assetLockTransaction!!.confidence.confidenceType == TransactionConfidence.ConfidenceType.BUILDING) { | ||
| assetLockTransaction!!.confidence.appearedAtChainHeight | ||
| } else { | ||
| DashSystem.get(wallet!!.params).blockChain.bestChainHeight | ||
| // this is not supported, how can we get the height? | ||
| // val txInfo = platform.client.getTransaction(assetLockTransaction!!.txId.toString()) | ||
| // txInfo?.height ?: -1 | ||
| }.toLong() | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This is moved out of the loop so that coreHeight is not updated every time a block is mined which would keep this function running forever.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some create/restore username issues