build: remove timestamp from gRPC cache to prevent unnecessary pushes#3219
Conversation
The `last_updated` timestamp in grpc-queries-cache.json changed on every CI run, causing the workflow to commit and push even when no query coverage actually changed. Combined with `cancel-in-progress: true`, this killed all sibling jobs on each push. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
❌ gRPC Query Coverage ReportTotal: 53 queries — 50 implemented, 2 ignored, 1 missing ❌ Missing
⏭️ Ignored (@sdk-ignore) (2)
✅ Implemented (50)
|
📝 WalkthroughWalkthroughRemoved timestamp tracking from the gRPC query cache: the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
https://github.com/dashpay/platform/actions/runs/22895929512/job/66429899713?pr=3219 - |
This reverts commit c7d9391.
shumkov
left a comment
There was a problem hiding this comment.
Are you sure cache gonna work properly without timeout? I think what needs to be done is just don't update it if no changes right?
It's not read anywhere, only writes. At least, I don't see it when I grep in v3.1-dev ;). |
Issue being fixed or feature implemented
The
check-grpc-coverageworkflow committed and pushed on every run becausesave_cache()wrotedatetime.now()into thelast_updatedfield. Since the timestamp always differs,git diffalways detected changes → commit → push →cancel-in-progress: truekilled all sibling jobs. This caused CI instability on every PR touching the coverage workflow paths.What was done?
last_updatedtimestamp field fromsave_cache()— the cache now only changes when actual query coverage changesfrom datetime import datetime(no longer needed)last_updatedfield fromgrpc-queries-cache.jsoncache_data.pop("last_updated", None)to strip legacy timestamps from existing cachesHow Has This Been Tested?
known_queries)git diff --quietcheck will now correctly report no changes when query coverage hasn't changedBreaking Changes
None.
Checklist:
🤖 Co-authored by Claudius the Magnificent AI Agent
Summary by CodeRabbit