Skip to content

chore: replace unmaintained paste crate with pastey#3238

Open
thepastaclaw wants to merge 1 commit intodashpay:v3.1-devfrom
thepastaclaw:chore/replace-paste-with-pastey
Open

chore: replace unmaintained paste crate with pastey#3238
thepastaclaw wants to merge 1 commit intodashpay:v3.1-devfrom
thepastaclaw:chore/replace-paste-with-pastey

Conversation

@thepastaclaw
Copy link
Collaborator

@thepastaclaw thepastaclaw commented Mar 12, 2026

Resolves #2487 (RUSTSEC-2024-0436)

What

Replaces the unmaintained paste crate with pastey, its API-compatible maintained fork.

Changes

  • packages/wasm-dpp/Cargo.toml: paste = "1.0.14"pastey = "0.2.1"
  • packages/wasm-dpp/src/errors/generic_consensus_error.rs: paste::pastepastey::paste

That's it — two lines. pastey is a drop-in replacement.

Validation

  • cargo check -p wasm-dpp

Summary by CodeRabbit

  • Chores
    • Replaced an internal build dependency with an alternative implementation.
    • No changes to public APIs, behavior, or error handling.
    • No user-visible impact expected; existing functionality remains unchanged.

@github-actions github-actions bot added this to the v3.1.0 milestone Mar 12, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5918622c-872d-4269-99ce-0adac9cd421c

📥 Commits

Reviewing files that changed from the base of the PR and between c935a9b and 8a2a015.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • packages/wasm-dpp/Cargo.toml
  • packages/wasm-dpp/src/errors/generic_consensus_error.rs

📝 Walkthrough

Walkthrough

Replaced the unmaintained paste crate with pastey in packages/wasm-dpp/Cargo.toml and switched the macro import in packages/wasm-dpp/src/errors/generic_consensus_error.rs to use pastey. No other code or public APIs were changed.

Changes

Cohort / File(s) Summary
Dependency Migration
packages/wasm-dpp/Cargo.toml, packages/wasm-dpp/src/errors/generic_consensus_error.rs
Replaced paste = "1.0.14" with pastey = "0.2.1" and updated macro usage/import in generic_consensus_error.rs to reference pastey.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇✨ I nibbled through Cargo, found an old paste,
Dug out pastey with haste, no time to waste.
Macros hopped on, tidy and new,
Errors still sing, the build stayed true. 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: replacing the unmaintained paste crate with pastey, an API-compatible maintained fork.
Linked Issues check ✅ Passed The PR successfully addresses RUSTSEC-2024-0436 by replacing the unmaintained paste crate with pastey, a maintained API-compatible alternative, as required.
Out of Scope Changes check ✅ Passed All changes are directly scoped to addressing the unmaintained dependency: only the dependency replacement in Cargo.toml and corresponding usage update in the error module.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PastaPastaPasta PastaPastaPasta changed the title chore(wasm-dpp): replace unmaintained paste crate with pastey chore: replace unmaintained paste crate with pastey Mar 12, 2026
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK; I've reviewed pastey, has stars, seems legit. It exists, and is a maintained fork of unmaintained paste. pastey is a drop in replacement, according to their docs.

@PastaPastaPasta PastaPastaPasta marked this pull request as ready for review March 12, 2026 20:13
@thepastaclaw thepastaclaw force-pushed the chore/replace-paste-with-pastey branch from 833dc98 to c935a9b Compare March 12, 2026 20:18
Resolves dashpay#2487 (RUSTSEC-2024-0436)

pastey is an API-compatible maintained fork of paste. The only direct
usage was in packages/wasm-dpp (Cargo.toml dependency + one import in
generic_consensus_error.rs).
@thepastaclaw thepastaclaw force-pushed the chore/replace-paste-with-pastey branch from c935a9b to 8a2a015 Compare March 12, 2026 20:34
@PastaPastaPasta PastaPastaPasta added the ready for final review Ready for the final review. If AI was involved in producing this PR, it has already had a reviewer. label Mar 12, 2026
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (0d10ecd) to head (8a2a015).
⚠️ Report is 2 commits behind head on v3.1-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           v3.1-dev   #3238       +/-   ##
============================================
- Coverage     55.87%       0   -55.88%     
============================================
  Files          3173       0     -3173     
  Lines        235215       0   -235215     
============================================
- Hits         131435       0   -131435     
+ Misses       103780       0   -103780     
Components Coverage Δ
dpp ∅ <ø> (∅)
drive ∅ <ø> (∅)
drive-abci ∅ <ø> (∅)
sdk ∅ <ø> (∅)
dapi-client ∅ <ø> (∅)
platform-version ∅ <ø> (∅)
platform-value ∅ <ø> (∅)
platform-wallet ∅ <ø> (∅)
drive-proof-verifier ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for final review Ready for the final review. If AI was involved in producing this PR, it has already had a reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RUSTSEC-2024-0436: paste - no longer maintained

2 participants