test(dpp): improve batch_transition test coverage

[QuantumExplorer]

Issue being fixed or feature implemented

Improve test coverage for the packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/ module. Currently this module has limited test coverage across its v0/v1 implementations, accessor dispatches, action type parsers, and resolver methods.

What was done?

Added 141 unit tests covering the batch_transition module:

• BatchTransitionV0 accessors: transitions_iter, transitions_len, transitions_are_empty, first_transition, first_transition_mut, contains_document_transition (always true), contains_token_transition (always false)
• BatchTransitionV0 methods: set_transitions (verifies token filtering), set_identity_contract_nonce, all_document_purchases_amount (none, single, multiple, overflow), all_conflicting_index_collateral_voting_funds (none, single, multiple, overflow, no prefunded)
• BatchTransitionV0 traits: StateTransitionLike (modified_data_ids, protocol_version, type, unique_identifiers), StateTransitionHasUserFeeIncrease, StateTransitionSingleSigned, StateTransitionOwned, StateTransitionIdentitySigned, FeatureVersioned
• BatchTransitionV1 accessors: All accessor methods including mixed document+token iteration, contains_document_transition (conditional), contains_token_transition (conditional)
• BatchTransitionV1 methods: set_transitions (preserves all types), set_identity_contract_nonce (both doc and token), purchase amounts and voting funds with overflow
• BatchTransitionV1 identity_signed: purpose_requirement logic for single token transfer, single token claim, multiple transitions, and empty transitions; security_level_requirement for TRANSFER vs AUTHENTICATION purpose
• Top-level BatchTransition enum: Dispatch tests for all trait methods across V0/V1 variants
• DocumentTransitionActionType: TryFrom<&str> for all valid types including aliases (updatePrice/update_price), invalid type error
• TokenTransitionActionType: TryFrom<&str> for all valid types with aliases, Display trait, action_type getter
• BatchedTransition/BatchedTransitionRef: borrow_as_ref, borrow_as_mut, set_identity_contract_nonce, to_owned_transition, data_contract_id, identity_contract_nonce
• Resolver methods: Both BatchedTransition and BatchedTransitionRef resolvers for document and token variants
• get_security_level_requirement: Default, specified level, invalid level fallback
• StateTransitionFieldTypes: binary_property_paths, identifiers_property_paths, signature_property_paths
• Fields constants: Verification of property name constants and default security level
• Iterator implementations: DocumentBatchIterator V0 and V1

How Has This Been Tested?

All 141 tests pass locally:

cargo test -p dpp --features "all_features" --lib batch_transition_tests
test result: ok. 141 passed; 0 failed; 0 ignored; 0 measured; 566 filtered out

Code formatted with cargo fmt --package dpp.

Breaking Changes

None. This PR only adds tests.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

Summary by CodeRabbit

• Tests
  • Expanded test coverage for batch transition state transitions, including validation of accessors, filtering logic, state transition behaviors, security level requirements, and error handling across multiple variants.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes add test infrastructure and a comprehensive test suite for batch transition state transitions. A test module declaration is added to mod.rs, followed by an extensive unit test file containing helper functions and test cases covering batch constructors, accessors, iterators, action type traits, and security requirements.

Changes

Cohort / File(s)	Summary
Test Module Scaffolding packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/mod.rs	Adds #[cfg(test)] mod tests; declaration to enable test module compilation.
Batch Transition Test Suite packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/tests.rs	Introduces comprehensive unit tests for batch transitions, including helper constructors for document/token transitions, batch variants (V0/V1), accessors, iterators, action type traits, security level requirements, and extensive validation across state transition functionality.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Hops of joy for tests so bright,
A thousand lines of coverage might,
Batch transitions checked with care,
Bugs won't slip—they'd never dare!
The test warren's growing deep,
Now the code can soundly sleep! 🧪✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'test(dpp): improve batch_transition test coverage' directly and accurately reflects the main change—adding comprehensive unit tests to improve test coverage for the batch_transition module.
Docstring Coverage	✅ Passed	Docstring coverage is 85.14% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch test/dpp-batch-transition-coverage

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.59%. Comparing base (882c255) to head (11668f8).
⚠️ Report is 6 commits behind head on v3.1-dev.

Additional details and impacted files

@@             Coverage Diff              @@
##           v3.1-dev    #3284      +/-   ##
============================================
+ Coverage     70.53%   70.59%   +0.05%     
============================================
  Files          3293     3293              
  Lines        263234   262901     -333     
============================================
- Hits         185683   185590      -93     
+ Misses        77551    77311     -240     

Components	Coverage Δ
dpp	58.97% <ø> (+0.38%)	⬆️
drive	78.18% <ø> (ø)
drive-abci	83.03% <ø> (-0.08%)	⬇️
sdk	31.25% <ø> (ø)
dapi-client	39.08% <ø> (ø)
platform-version	∅ <ø> (∅)
platform-value	39.35% <ø> (ø)
platform-wallet	60.40% <ø> (ø)
drive-proof-verifier	∅ <ø> (∅)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

🧹 Nitpick comments (1)

packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/tests.rs (1)

1-2: Redundant #[cfg(test)] attribute.

The #[cfg(test)] on line 1 is redundant since this module is already conditionally compiled via #[cfg(test)] mod tests; in mod.rs. While harmless, you can remove it for cleaner code.

♻️ Suggested fix

-#[cfg(test)]
 mod batch_transition_tests {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/tests.rs`
around lines 1 - 2, Remove the redundant #[cfg(test)] attribute on the module
declaration for batch_transition_tests: locate the mod batch_transition_tests {
... } block in tests.rs and delete the #[cfg(test)] above it (the module is
already conditionally compiled via the tests module in mod.rs), leaving the
module definition intact.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/tests.rs`:
- Around line 1-2: Remove the redundant #[cfg(test)] attribute on the module
declaration for batch_transition_tests: locate the mod batch_transition_tests {
... } block in tests.rs and delete the #[cfg(test)] above it (the module is
already conditionally compiled via the tests module in mod.rs), leaving the
module definition intact.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b105ad0c-11c6-49ff-9fc9-d81523522af1

📥 Commits

Reviewing files that changed from the base of the PR and between 882c255 and 11668f8.

📒 Files selected for processing (2)

• packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/mod.rs
• packages/rs-dpp/src/state_transition/state_transitions/document/batch_transition/tests.rs